Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663253005: Add src-side launcher for nacl integration tests (Closed)

Created:
6 years, 1 month ago by Paweł Hajdan Jr.
Modified:
6 years, 1 month ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add src-side launcher for nacl integration tests Also enable it on Windows, Linux, and Mac. BUG=422235 R=sergiyb@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/dc2c3366b19b17168055e12de9e011d0efc1ee39

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M testing/buildbot/chromium.linux.json View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 2 chunks +12 lines, -0 lines 0 comments Download
A + testing/scripts/nacl_integration.py View 1 chunk +13 lines, -10 lines 3 comments Download

Messages

Total messages: 7 (1 generated)
Paweł Hajdan Jr.
6 years, 1 month ago (2014-10-29 13:22:10 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/663253005/diff/1/testing/scripts/nacl_integration.py File testing/scripts/nacl_integration.py (left): https://codereview.chromium.org/663253005/diff/1/testing/scripts/nacl_integration.py#oldcode17 testing/scripts/nacl_integration.py:17: os.path.join(common.SRC_DIR, 'buildtools', 'checkdeps', 'checkdeps.py'), Why was nacl_intergration.py running checkdeps ...
6 years, 1 month ago (2014-10-30 11:39:59 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/663253005/diff/1/testing/scripts/nacl_integration.py File testing/scripts/nacl_integration.py (left): https://codereview.chromium.org/663253005/diff/1/testing/scripts/nacl_integration.py#oldcode17 testing/scripts/nacl_integration.py:17: os.path.join(common.SRC_DIR, 'buildtools', 'checkdeps', 'checkdeps.py'), On 2014/10/30 11:39:59, Sergiy Byelozyorov ...
6 years, 1 month ago (2014-10-30 16:17:36 UTC) #4
Sergiy Byelozyorov
lgtm https://codereview.chromium.org/663253005/diff/1/testing/scripts/nacl_integration.py File testing/scripts/nacl_integration.py (left): https://codereview.chromium.org/663253005/diff/1/testing/scripts/nacl_integration.py#oldcode17 testing/scripts/nacl_integration.py:17: os.path.join(common.SRC_DIR, 'buildtools', 'checkdeps', 'checkdeps.py'), On 2014/10/30 16:17:36, Paweł ...
6 years, 1 month ago (2014-10-31 14:09:20 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dc2c3366b19b17168055e12de9e011d0efc1ee39 Cr-Commit-Position: refs/heads/master@{#302423}
6 years, 1 month ago (2014-11-03 12:33:18 UTC) #6
Paweł Hajdan Jr.
6 years, 1 month ago (2014-11-03 14:41:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dc2c3366b19b17168055e12de9e011d0efc1ee39.

Powered by Google App Engine
This is Rietveld 408576698