Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 663253003: Fix more android build issues (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, DaveMoore
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Fix more android build issues - xdisplaycheck isn't needed on android - some files in ui/base are gone now R=sky@chromium.org, ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3be077cc35eef45d52d2036bd73bd88fb7e0e148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
M ui/android/BUILD.gn View 2 chunks +0 lines, -13 lines 0 comments Download
M ui/base/android/ui_base_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
6 years, 2 months ago (2014-10-24 01:03:27 UTC) #1
jamesr
r->sky since beng@'s out today
6 years, 2 months ago (2014-10-24 21:08:04 UTC) #3
sky
LGTM
6 years, 2 months ago (2014-10-24 21:10:14 UTC) #4
jamesr
6 years, 2 months ago (2014-10-24 21:56:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3be077cc35eef45d52d2036bd73bd88fb7e0e148 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698