cc/PRESUBMIT.py - Issue 663243003: Clean up final uses of scoped_ptr<T>::PassAs() and remove it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/PRESUBMIT.py

Issue 663243003: Clean up final uses of scoped_ptr<T>::PassAs() and remove it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/PRESUBMIT.py

diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py

index 1aa48f3501ad2d186b20b626ae2de8013bb40423..03931614b81fddbc895a7f5fb5f4ad62d0d5c866 100644

--- a/cc/PRESUBMIT.py

+++ b/cc/PRESUBMIT.py

@@ -191,12 +191,6 @@ def CheckScopedPtr(input_api, output_api,

errors.append(output_api.PresubmitError(

'%s:%d uses scoped_ptr<T>(). Use nullptr instead.' %

(f.LocalPath(), line_number)))

- # Disallow:

- # foo.PassAs<T>();

- if re.search(r'\bPassAs<.*?>\(\)', line):

- errors.append(output_api.PresubmitError(

- '%s:%d uses PassAs<T>(). Use Pass() instead.' %

- (f.LocalPath(), line_number)))

return errors

def FindUnquotedQuote(contents, pos):

« no previous file with comments | « base/memory/scoped_ptr_unittest.cc ('k') | net/socket/ssl_client_socket_unittest.cc » ('j') | no next file with comments »