Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 663243003: Clean up final uses of scoped_ptr<T>::PassAs() and remove it. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
danakj, Ryan Sleevi
CC:
cbentzel+watch_chromium.org, cc-bugs_chromium.org, chromium-reviews, davidben, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up final uses of scoped_ptr<T>::PassAs() and remove it. This helper to upcast in return statements is no longer needed. BUG=423621 Committed: https://crrev.com/19b6b65f39712670a4bf8289cdeb4992c62ef27c Cr-Commit-Position: refs/heads/master@{#300548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -50 lines) Patch
M base/memory/scoped_ptr.h View 2 chunks +0 lines, -21 lines 0 comments Download
M base/memory/scoped_ptr_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M cc/PRESUBMIT.py View 1 chunk +0 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dcheng
All hail C++11.
6 years, 2 months ago (2014-10-21 01:29:30 UTC) #2
dcheng
(danakj for base + cc changes, rsleevi for net changes)
6 years, 2 months ago (2014-10-21 01:29:41 UTC) #3
danakj
On 2014/10/21 01:29:41, dcheng wrote: > (danakj for base + cc changes, rsleevi for net ...
6 years, 2 months ago (2014-10-21 16:01:13 UTC) #4
Ryan Sleevi
lgtm
6 years, 2 months ago (2014-10-21 17:44:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663243003/1
6 years, 2 months ago (2014-10-21 17:47:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/66216)
6 years, 2 months ago (2014-10-21 19:41:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663243003/1
6 years, 2 months ago (2014-10-21 20:01:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 20:30:12 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 20:31:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19b6b65f39712670a4bf8289cdeb4992c62ef27c
Cr-Commit-Position: refs/heads/master@{#300548}

Powered by Google App Engine
This is Rietveld 408576698