LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html - Issue 66323004: XHR: compliant event sequencing on request errors and aborts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html

Issue 66323004: XHR: compliant event sequencing on request errors and aborts. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve test code quality Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match.html ('k') | Source/core/xml/XMLHttpRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html

diff --git a/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html b/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html

index 4ce6207e56cfde737da3060c8d161102327ea493..981e0e03aa7238374b8aebfa8a3284aaf45ef770 100644

--- a/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html

+++ b/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html

@@ -1,3 +1,4 @@

+<!doctype html>

<html>

<head>

@@ -16,6 +17,10 @@ function log(msg)

}

function onProgress(e) {

+ if (this.seenProgress)

+ return;

+ this.seenProgress = true;

log("PASSED (" + count + ")");

if (++count > 2 && window.testRunner)

testRunner.notifyDone();

@@ -29,12 +34,14 @@ if (window.testRunner) {

// Test for capture phase

var req3 = new XMLHttpRequest();

req3.addEventListener("progress", onProgress, true);

+req3.seenProgress = false;

req3.open("GET", "resources/1251.html", true);

req3.send(null);

// Test for bubble phase

var req4 = new XMLHttpRequest();

req4.addEventListener("progress", onProgress, false);

+req4.seenProgress = false;

req4.open("GET", "resources/1251.html", true);

req4.send(null);