Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Side by Side Diff: Source/core/xml/XMLHttpRequestUpload.cpp

Issue 66323004: XHR: compliant event sequencing on request errors and aborts. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve test code quality Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/xml/XMLHttpRequestUpload.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 } 61 }
62 62
63 void XMLHttpRequestUpload::dispatchEventAndLoadEnd(PassRefPtr<Event> event) 63 void XMLHttpRequestUpload::dispatchEventAndLoadEnd(PassRefPtr<Event> event)
64 { 64 {
65 ASSERT(event->type() == EventTypeNames::load || event->type() == EventTypeNa mes::abort || event->type() == EventTypeNames::error || event->type() == EventTy peNames::timeout); 65 ASSERT(event->type() == EventTypeNames::load || event->type() == EventTypeNa mes::abort || event->type() == EventTypeNames::error || event->type() == EventTy peNames::timeout);
66 66
67 dispatchEvent(event); 67 dispatchEvent(event);
68 dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::loadend)); 68 dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::loadend));
69 } 69 }
70 70
71 71 void XMLHttpRequestUpload::handleRequestError(const AtomicString& type)
72 {
73 dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::progress, true, m_lastBytesSent, m_lastTotalBytesToBeSent));
74 dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent::create(type));
75 }
72 76
73 } // namespace WebCore 77 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/xml/XMLHttpRequestUpload.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698