Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 663203002: Force reset of RenderViewImpl zoom level. (Closed)

Created:
6 years, 2 months ago by wjmaclean
Modified:
6 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Force reset of RenderViewImpl zoom level. When navigation away from a page fails, the displayed error page uses the zoom level of the current page since the underlying RenderViewImpl is re-used without resetting its zoom level before displaying the error page. This CL forces the RenderViewImpl's zoom level to be reset to 0 whenever the url being navigated to is unkown to the RenderViewImpl. BUG=422464 Committed: https://crrev.com/263e86f88ffc1c8587a5d3141fbc5d6f0ca8519b Cr-Commit-Position: refs/heads/master@{#300352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
wjmaclean
nasko@ - Can you take a look at this? I believe you wrote the surrounding ...
6 years, 2 months ago (2014-10-20 19:20:00 UTC) #2
nasko
LGTM
6 years, 2 months ago (2014-10-20 20:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663203002/1
6 years, 2 months ago (2014-10-20 20:44:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 22:22:30 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:23:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/263e86f88ffc1c8587a5d3141fbc5d6f0ca8519b
Cr-Commit-Position: refs/heads/master@{#300352}

Powered by Google App Engine
This is Rietveld 408576698