Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: content/renderer/pepper/pepper_video_source_host.cc

Issue 663183002: ppapi: Change endianness in libyuv calls, from BGRA to ARGB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: automatically detect endianness Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_video_source_host.cc
diff --git a/content/renderer/pepper/pepper_video_source_host.cc b/content/renderer/pepper/pepper_video_source_host.cc
index bdad9651e2238fe3d4d23fa51c99fab98b76dd80..354e37d3b89406c5d12e05e3cab88f64cc697d36 100644
--- a/content/renderer/pepper/pepper_video_source_host.cc
+++ b/content/renderer/pepper/pepper_video_source_host.cc
@@ -182,7 +182,7 @@ void PepperVideoSourceHost::SendGetFrameReply() {
const uint8* src_v = frame->data(media::VideoFrame::kVPlane) +
(center * vert_crop + horiz_crop) / 2;
- libyuv::I420ToBGRA(src_y,
+ libyuv::I420ToARGB(src_y,
frame->stride(media::VideoFrame::kYPlane),
src_u,
frame->stride(media::VideoFrame::kUPlane),
@@ -192,6 +192,10 @@ void PepperVideoSourceHost::SendGetFrameReply() {
bitmap->rowBytes(),
dst_width,
dst_height);
+ // Give an imperceptible hint about endianness in the first pixel. The alpha
+ // channel is always 255, if B is 255 as well, change it to 254.
+ if (bitmap_pixels[0] == 255)
+ bitmap_pixels[0] = 254;
ppapi::HostResource host_resource;
host_resource.SetHostResource(pp_instance(), resource.get());

Powered by Google App Engine
This is Rietveld 408576698