ppapi: Change endianness in libyuv calls, from BGRA to ARGB

content/renderer/media/webrtc/video_destination_handler.cc

Index: content/renderer/media/webrtc/video_destination_handler.cc
diff --git a/content/renderer/media/webrtc/video_destination_handler.cc b/content/renderer/media/webrtc/video_destination_handler.cc
index 160537165d7912e4c514f6d49272f9dd60d0adde..a5f9296386cc06de0ba19514b459bb8af9aa9ee6 100644
--- a/content/renderer/media/webrtc/video_destination_handler.cc
+++ b/content/renderer/media/webrtc/video_destination_handler.cc
@@ -101,6 +101,8 @@ void PpFrameWriter::FrameWriterDelegate::DeliverFrame(
                << "The image_data's mapped bitmap is NULL.";
     return;
   }
+  // We only support PP_IMAGEDATAFORMAT_BGRA_PREMUL at the moment.
+  DCHECK(image_data->format() == PP_IMAGEDATAFORMAT_BGRA_PREMUL);

[fbarchard, 2014/10/21 01:02:57]

FYI our effects code is normally unattenuated.

   io_message_loop_->PostTaskAndReply(
       FROM_HERE,
       base::Bind(&FrameWriterDelegate::DeliverFrameOnIO, this,
@@ -153,7 +155,7 @@ void PpFrameWriter::FrameWriterDelegate::DeliverFrameOnIO(
       MediaStreamVideoSource::kUnknownFrameRate,
       media::PIXEL_FORMAT_YV12);
 
-  libyuv::BGRAToI420(data,
+  libyuv::ARGBToI420(data,

[fbarchard, 2014/10/21 01:02:57]

note that this has immediate performance benefit - windows version will use
AVX2, which is about 40% faster on haswell.

                      stride,
                      new_frame->data(media::VideoFrame::kYPlane),
                      new_frame->stride(media::VideoFrame::kYPlane),