Adding build rules for fuzzer (internal only)

Adding build rules for fuzzer (internal only)

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236050

[sugoi1, 2013-11-19 15:16:24]

https://codereview.chromium.org/66313008/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/66313008/diff/1/build/common.gypi#newcode1122
build/common.gypi:1122: 'internal_filter_fuzzer%': 0,
This turns the compilation of the fuzzer OFF, so nothing new will build with
this cl used as is. You need to set it to 1 in order to compile it.

[Stephen White, 2013-11-19 16:07:55]

https://codereview.chromium.org/66313008/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/66313008/diff/1/build/all.gyp#newcode616
build/all.gyp:616: ['internal_filter_fuzzer', {
I think this should be 'internal_filter_fuzzer==1', like the subsequent stanzas,
for clarity.

[sugoi1, 2013-11-19 16:20:58]

https://codereview.chromium.org/66313008/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/66313008/diff/1/build/all.gyp#newcode616
build/all.gyp:616: ['internal_filter_fuzzer', {
On 2013/11/19 16:07:55, Stephen White wrote:
> I think this should be 'internal_filter_fuzzer==1', like the subsequent
stanzas,
> for clarity.

Done.

[Stephen White, 2013-11-19 16:31:25]

LGTM

[commit-bot: I haz the power, 2013-11-19 16:37:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sugoi@chromium.org/66313008/90001

[commit-bot: I haz the power, 2013-11-19 18:32:52]

Retried try job too often on win_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-19 18:42:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sugoi@chromium.org/66313008/90001

[commit-bot: I haz the power, 2013-11-19 22:04:16]

Change committed as 236050

[Nico, 2016-06-10 17:25:34]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-06-10 17:25:34]

As far as I can tell nothing sets this (anymore?). Can I delete this again?

[Stephen White, 2016-06-10 17:28:18]

On 2016/06/10 17:25:34, Nico (traveling...slow) wrote:
> As far as I can tell nothing sets this (anymore?). Can I delete this again?

I think this is needed when building the image filter fuzzer. It's built
manually, and hand-uploaded to the fuzzing infrastructure, IIRC.

sugoi@ to confirm.

[Nico, 2016-06-10 17:29:24]

But why is this part of chromium_builder_asan then?

(Also, this doesn't exist in the gn build; if you need it, you should port it to
there very soon :-) )

[Martin Barbella, 2016-06-10 17:33:18]

On 2016/06/10 17:29:24, Nico (traveling...slow) wrote:
> But why is this part of chromium_builder_asan then?
> 
> (Also, this doesn't exist in the gn build; if you need it, you should port it
to
> there very soon :-) )

We do still need this fuzzer, but we should consider moving it out of
chrome-internal and including it in chromium_builder_asan so that the uploads
don't need to be manual. The original reasoning for keeping it private was that
we had a lot of issues it would expose, but it only catches regressions at this
point.

[sugoi1, 2016-06-10 21:32:24]

On 2016/06/10 17:33:18, Martin Barbella wrote:
> On 2016/06/10 17:29:24, Nico (traveling...slow) wrote:
> > But why is this part of chromium_builder_asan then?
> > 
> > (Also, this doesn't exist in the gn build; if you need it, you should port
it
> to
> > there very soon :-) )
> 
> We do still need this fuzzer, but we should consider moving it out of
> chrome-internal and including it in chromium_builder_asan so that the uploads
> don't need to be manual. The original reasoning for keeping it private was
that
> we had a lot of issues it would expose, but it only catches regressions at
this
> point.

Yes, this is probably still needed. This fuzzer still runs on clusterfuzz and
tests
skia serialization regularly. I haven't been working in skia for about a year
and a
half, though, so maybe senorblanco@ would have an opinion on the subject
(he's on vacation for about a month, so I hope this can wait).

[Martin Barbella, 2016-06-10 21:43:21]

On 2016/06/10 21:32:24, sugoi1 wrote:
> On 2016/06/10 17:33:18, Martin Barbella wrote:
> > On 2016/06/10 17:29:24, Nico (traveling...slow) wrote:
> > > But why is this part of chromium_builder_asan then?
> > > 
> > > (Also, this doesn't exist in the gn build; if you need it, you should port
> it
> > to
> > > there very soon :-) )
> > 
> > We do still need this fuzzer, but we should consider moving it out of
> > chrome-internal and including it in chromium_builder_asan so that the
uploads
> > don't need to be manual. The original reasoning for keeping it private was
> that
> > we had a lot of issues it would expose, but it only catches regressions at
> this
> > point.
> 
> Yes, this is probably still needed. This fuzzer still runs on clusterfuzz and
> tests
> skia serialization regularly. I haven't been working in skia for about a year
> and a
> half, though, so maybe senorblanco@ would have an opinion on the subject
> (he's on vacation for about a month, so I hope this can wait).

Feel free to file a bug for this. If it's urgent, assign it to me.

[Nico, 2016-06-10 21:49:41]

At the moment, no bot (including cf) sets this define though
On Jun 10, 2016 5:32 PM, <sugoi@chromium.org> wrote:

> Reviewers: mbarbella (wrong one), aarya, senorblanco, Stephen White away
> til July 11, Nico (traveling...slow)
> CL: https://codereview.chromium.org/66313008/
>
> Message:
> On 2016/06/10 17:33:18, Martin Barbella wrote:
> > On 2016/06/10 17:29:24, Nico (traveling...slow) wrote:
> > > But why is this part of chromium_builder_asan then?
> > >
> > > (Also, this doesn't exist in the gn build; if you need it, you should
> port
> it
> > to
> > > there very soon :-) )
> >
> > We do still need this fuzzer, but we should consider moving it out of
> > chrome-internal and including it in chromium_builder_asan so that the
> uploads
> > don't need to be manual. The original reasoning for keeping it private
> was
> that
> > we had a lot of issues it would expose, but it only catches regressions
> at
> this
> > point.
>
> Yes, this is probably still needed. This fuzzer still runs on clusterfuzz
> and
> tests
> skia serialization regularly. I haven't been working in skia for about a
> year
> and a
> half, though, so maybe senorblanco@ would have an opinion on the subject
> (he's on vacation for about a month, so I hope this can wait).
>
> Description:
> Adding build rules for fuzzer (internal only)
>
> BUG=
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236050
>
> Base URL: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+8, -0 lines):
> M build/all.gyp
> M build/common.gypi
>
>
> Index: build/all.gyp
> diff --git a/build/all.gyp b/build/all.gyp
> index
>
190104922d0bb68d274a8d83e4e0281c50c92dcd..81e9c796719b8d6dd515240b0a8eebb9065687cd
> 100644
> --- a/build/all.gyp
> +++ b/build/all.gyp
> @@ -613,6 +613,11 @@
> '../skia/skia.gyp:filter_fuzz_stub',
> ],
> }],
> + ['internal_filter_fuzzer==1', {
> + 'dependencies': [
> + '../skia/tools/filter_fuzzer/filter_fuzzer.gyp:filter_fuzzer',
> + ],
> + }], # internal_filter_fuzzer
> ['OS=="win" and fastbuild==0 and target_arch=="ia32"', {
> 'dependencies': [
> '../chrome/chrome_syzygy.gyp:chrome_dll_syzygy',
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
6f40a2ca91bbf0043c27c863ef8809e55bbb4b12..da9ee7931354b05c429dcbb99223da69da30ba2d
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -1118,6 +1118,9 @@
> # Set to 1 to compile with the OpenGL ES 2.0 conformance tests.
> 'internal_gles2_conform_tests%': 0,
>
> + # Set to 1 to compile the filter fuzzer.
> + 'internal_filter_fuzzer%': 0,
> +
> # NOTE: When these end up in the Mac bundle, we need to replace '-' for '_'
> # so Cocoa is happy (http://crbug.com/20441).
> 'locales': [
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Martin Barbella, 2016-06-10 21:51:05]

mbarbella@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Martin Barbella, 2016-06-10 21:51:06]

Yes, that's true. It's been built and uploaded to CF manually. I think we should
actually set it up to build with the chromium_builder_asan target and move it
out of chrome-internal. I should have been clearer in my last comment.