Issue 66313007: [Blink] Adding Writing direction to the context menu for linux gtk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66313007: [Blink] Adding Writing direction to the context menu for linux gtk (Closed)

Created:
7 years, 1 month ago by pals

Modified:
7 years, 1 month ago

Reviewers:
eseidel

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, Elliot Glaysher, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Blink side changes for adding Writing direction to the context menu for linux gtk Chromium side CL is here https://codereview.chromium.org/73963004/ BUG=91178 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162341

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/web/ContextMenuClientImpl.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	public/web/WebContextMenuData.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

eseidel

lgtm My impression is that Gtk is dead, long live Aura. But I'm not sure ...

7 years, 1 month ago (2013-11-19 19:08:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/66313007/1

7 years, 1 month ago (2013-11-20 05:27:53 UTC) #3

Message was sent while issue was closed.

Change committed as 162341