Reduce power logging and UMA stats when AGC is disabled

Reduce power logging and UMA stats when AGC is disabled.

Sets a const bool member when AIC is constructed and uses that member to access the stream AGC setting on the correct thread. Same member also enables or disables power logging.

In short: should reduce logging for all non-WebRTC clients.

BUG=408967
TEST=WebRTC clients checking DVLOGs.

Committed: https://crrev.com/4159b37157a2f32c6a15cf5a4cef8f6e8f4bd24e
Cr-Commit-Position: refs/heads/master@{#300664}

[henrika (OOO until Aug 14), 2014-10-20 14:22:12]

henrika@chromium.org changed reviewers:
+ tommi@chromium.org

[henrika (OOO until Aug 14), 2014-10-20 14:26:48]

Tommi, as discussed off-line. Please check. Thanks.

[tommi (sloooow) - chröme, 2014-10-20 16:03:28]

https://codereview.chromium.org/663123002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/media/audio_input_renderer_host.cc (right):

https://codereview.chromium.org/663123002/diff/40001/content/browser/renderer...
content/browser/renderer_host/media/audio_input_renderer_host.cc:396:
media::AudioParameters::AUDIO_PCM_LOW_LATENCY &&
if format() is not 'low latency' bug we call CreateLowLatency here regardless,
is that a bug?

I'm wondering if we should just pass config.automatic_gain_control and skip the
temporary variable.
(and possibly DCHECK on AUDIO_PCM_LOW_LATENCY)

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:275: // Disable power monitoring for
streams which runs without AGC enabled to
nit: s/which runs/that run

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:331: // Changing the AGC state is not
supported while recording is active.
this comment and the line that follows are a bit confusing...

[henrika (OOO until Aug 14), 2014-10-21 08:00:28]

PTAL Tommi. Thanks.

https://codereview.chromium.org/663123002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/media/audio_input_renderer_host.cc (right):

https://codereview.chromium.org/663123002/diff/40001/content/browser/renderer...
content/browser/renderer_host/media/audio_input_renderer_host.cc:396:
media::AudioParameters::AUDIO_PCM_LOW_LATENCY &&
Good point. I had the same idea but did not want to change too much. But you are
correct. We might as well make the change now.

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:275: // Disable power monitoring for
streams which runs without AGC enabled to
On 2014/10/20 16:03:28, tommi wrote:
> nit: s/which runs/that run

Done.

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:331: // Changing the AGC state is not
supported while recording is active.
On 2014/10/20 16:03:28, tommi wrote:
> this comment and the line that follows are a bit confusing...

Acknowledged.

[tommi (sloooow) - chröme, 2014-10-21 10:09:03]

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:275: // Disable power monitoring for
streams which runs without AGC enabled to
On 2014/10/21 08:00:28, henrika wrote:
> On 2014/10/20 16:03:28, tommi wrote:
> > nit: s/which runs/that run
> 
> Done.

nit: runs -> run

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:331: // Changing the AGC state is not
supported while recording is active.
On 2014/10/21 08:00:28, henrika wrote:
> On 2014/10/20 16:03:28, tommi wrote:
> > this comment and the line that follows are a bit confusing...
> 
> Acknowledged.

Why is this call needed?

[henrika (OOO until Aug 14), 2014-10-21 10:24:06]

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:275: // Disable power monitoring for
streams which runs without AGC enabled to
On 2014/10/21 10:09:03, tommi wrote:
> On 2014/10/21 08:00:28, henrika wrote:
> > On 2014/10/20 16:03:28, tommi wrote:
> > > nit: s/which runs/that run
> > 
> > Done.
> 
> nit: runs -> run

Done.

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:331: // Changing the AGC state is not
supported while recording is active.
If we did not make this call the AGC would not be enabled. Each input stream
uses this state to activate/deactivate the AGC.

[tommi (sloooow) - chröme, 2014-10-21 14:17:17]

lgtm

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/663123002/diff/40001/media/audio/audio_input_...
media/audio/audio_input_controller.cc:331: // Changing the AGC state is not
supported while recording is active.
On 2014/10/21 10:24:06, henrika wrote:
> If we did not make this call the AGC would not be enabled. Each input stream
> uses this state to activate/deactivate the AGC.

Thanks.  code search failed me :)

[henrika (OOO until Aug 14), 2014-10-21 15:38:36]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2014-10-21 15:39:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663123002/80001

[commit-bot: I haz the power, 2014-10-21 15:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 15:44:09]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71371)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[henrika (OOO until Aug 14), 2014-10-21 15:52:33]

Looks like I have to rebase. Will fix this tomorrow.

[henrika (OOO until Aug 14), 2014-10-22 09:51:48]

The CQ bit was checked by henrika@chromium.org

[henrika (OOO until Aug 14), 2014-10-22 09:51:51]

The CQ bit was unchecked by henrika@chromium.org

[henrika (OOO until Aug 14), 2014-10-22 09:52:23]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2014-10-22 09:52:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663123002/100001

[commit-bot: I haz the power, 2014-10-22 11:08:41]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-22 11:09:21]

Patchset 6 (id:??) landed as
https://crrev.com/4159b37157a2f32c6a15cf5a4cef8f6e8f4bd24e
Cr-Commit-Position: refs/heads/master@{#300664}