Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663093003: Move minidump/*_test_util.* to minidump/test (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -797 lines) Patch
M minidump/minidump.gyp View 1 chunk +8 lines, -8 lines 0 comments Download
D minidump/minidump_context_test_util.h View 1 chunk +0 lines, -61 lines 0 comments Download
D minidump/minidump_context_test_util.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M minidump/minidump_context_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_crashpad_info_writer_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M minidump/minidump_file_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D minidump/minidump_file_writer_test_util.h View 1 chunk +0 lines, -41 lines 0 comments Download
D minidump/minidump_file_writer_test_util.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D minidump/minidump_memory_writer_test_util.h View 1 chunk +0 lines, -104 lines 0 comments Download
D minidump/minidump_memory_writer_test_util.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_simple_string_dictionary_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D minidump/minidump_string_writer_test_util.h View 1 chunk +0 lines, -42 lines 0 comments Download
D minidump/minidump_string_writer_test_util.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_thread_writer_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + minidump/test/minidump_context_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + minidump/test/minidump_context_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + minidump/test/minidump_file_writer_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + minidump/test/minidump_file_writer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + minidump/test/minidump_memory_writer_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + minidump/test/minidump_memory_writer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + minidump/test/minidump_string_writer_test_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
A + minidump/test/minidump_string_writer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-20 16:06:40 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-20 16:10:41 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-20 16:11:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
01c535b0011ef2bfad5697d9b45038f25a917fe2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698