Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 663083005: Revert of [Base] Use variadic template in callback_list.h (wave 1) (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
awong, tzik
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Base] Use variadic template in callback_list.h (wave 1) (patchset #1 id:1 of https://codereview.chromium.org/618573002/) Reason for revert: Breaking compilation on windows with MSVC Express. Original issue's description: > [Base] Use variadic template in callback_list.h > > Replace pump.py generated base/callback_list.h with variadic template version. > > BUG=None > > Committed: https://crrev.com/a28756fae426023c53542f08c1bf80397a28f677 > Cr-Commit-Position: refs/heads/master@{#298529} TBR=ajwong@chromium.org,tzik@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/69e698364a0a82a806fc5a4994c5f2040d1ff083 Cr-Commit-Position: refs/heads/master@{#300487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -15 lines) Patch
M base/callback_list.h View 2 chunks +191 lines, -15 lines 0 comments Download
A base/callback_list.h.pump View 1 chunk +269 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lfg
Created Revert of [Base] Use variadic template in callback_list.h (wave 1)
6 years, 2 months ago (2014-10-21 14:53:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663083005/1
6 years, 2 months ago (2014-10-21 14:54:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 14:55:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/69e698364a0a82a806fc5a4994c5f2040d1ff083 Cr-Commit-Position: refs/heads/master@{#300487}
6 years, 2 months ago (2014-10-21 14:56:15 UTC) #4
Nico
6 years, 1 month ago (2014-11-20 01:13:15 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/744503002/ by thakis@chromium.org.

The reason for reverting is: We now don't support building with MSVC Express any
more. Do shout if this change causes problems for your compiler, though.

This is part of http://crbug.com/433164.

Powered by Google App Engine
This is Rietveld 408576698