Source/devtools/front_end/timeline/TracingTimelineUIUtils.js - Issue 663083004: [DevTools] Remove remaining usages of global properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 663083004: [DevTools] Remove remaining usages of global properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

diff --git a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

index 365e3757bbe713d847034d0b287391c0d843bd53..f3b180ff16d009fcbb58e6cd813c68124f1ffed0 100644

--- a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

+++ b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

@@ -793,8 +793,7 @@ WebInspector.TracingTimelineUIUtils._generateInvalidationsForType = function(typ

break;

}

- var detailsNode = document.createElement("div");

- detailsNode.className = "timeline-details-view-row";

+ var detailsNode = createElementWithClass("div", "timeline-details-view-row");

apavlov 2014/10/21 15:15:38 unrelated?

dgozman 2014/10/22 08:04:03 Related. I've changed all document.createElement t

var titleElement = detailsNode.createChild("span", "timeline-details-view-row-title");

titleElement.textContent = WebInspector.UIString("%s: ", title);

var eventsList = detailsNode.createChild("ol");