Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 663083004: [DevTools] Remove remaining usages of global properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.TimelineUIUtils} 7 * @extends {WebInspector.TimelineUIUtils}
8 */ 8 */
9 WebInspector.TracingTimelineUIUtils = function() 9 WebInspector.TracingTimelineUIUtils = function()
10 { 10 {
(...skipping 775 matching lines...) Expand 10 before | Expand all | Expand 10 after
786 title = WebInspector.UIString("Style invalidations"); 786 title = WebInspector.UIString("Style invalidations");
787 break; 787 break;
788 case WebInspector.TracingTimelineModel.RecordType.LayoutInvalidationTracking : 788 case WebInspector.TracingTimelineModel.RecordType.LayoutInvalidationTracking :
789 title = WebInspector.UIString("Layout invalidations"); 789 title = WebInspector.UIString("Layout invalidations");
790 break; 790 break;
791 default: 791 default:
792 title = WebInspector.UIString("Other invalidations"); 792 title = WebInspector.UIString("Other invalidations");
793 break; 793 break;
794 } 794 }
795 795
796 var detailsNode = document.createElement("div"); 796 var detailsNode = createElementWithClass("div", "timeline-details-view-row") ;
797 detailsNode.className = "timeline-details-view-row";
798 var titleElement = detailsNode.createChild("span", "timeline-details-view-ro w-title"); 797 var titleElement = detailsNode.createChild("span", "timeline-details-view-ro w-title");
799 titleElement.textContent = WebInspector.UIString("%s: ", title); 798 titleElement.textContent = WebInspector.UIString("%s: ", title);
800 var eventsList = detailsNode.createChild("ol"); 799 var eventsList = detailsNode.createChild("ol");
801 invalidationEvents.forEach(appendInvalidations); 800 invalidationEvents.forEach(appendInvalidations);
802 801
803 contentHelper.element.appendChild(detailsNode); 802 contentHelper.element.appendChild(detailsNode);
804 803
805 804
806 function appendInvalidations(invalidation, index) 805 function appendInvalidations(invalidation, index)
807 { 806 {
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 return result; 983 return result;
985 } 984 }
986 985
987 /** 986 /**
988 * @return {!WebInspector.TracingTimelineModel.Filter} 987 * @return {!WebInspector.TracingTimelineModel.Filter}
989 */ 988 */
990 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function() 989 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function()
991 { 990 {
992 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes()); 991 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes());
993 } 992 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | Source/devtools/front_end/toolbox_bootstrap/Toolbox.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698