Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: net/spdy/spdy_protocol_test.cc

Issue 663043004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_protocol.h" 5 #include "net/spdy/spdy_protocol.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "net/spdy/spdy_bitmasks.h" 11 #include "net/spdy/spdy_bitmasks.h"
12 #include "net/spdy/spdy_framer.h" 12 #include "net/spdy/spdy_framer.h"
13 #include "net/test/gtest_util.h" 13 #include "net/test/gtest_util.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace { 16 namespace {
17 17
18 enum SpdyProtocolTestTypes { 18 enum SpdyProtocolTestTypes {
19 SPDY2 = net::SPDY2, 19 SPDY2 = net::SPDY2,
20 SPDY3 = net::SPDY3, 20 SPDY3 = net::SPDY3,
21 }; 21 };
22 22
23 } // namespace 23 } // namespace
24 24
25 namespace net { 25 namespace net {
26 26
27 class SpdyProtocolTest 27 class SpdyProtocolTest
28 : public ::testing::TestWithParam<SpdyProtocolTestTypes> { 28 : public ::testing::TestWithParam<SpdyProtocolTestTypes> {
29 protected: 29 protected:
30 virtual void SetUp() { 30 void SetUp() override {
31 spdy_version_ = static_cast<SpdyMajorVersion>(GetParam()); 31 spdy_version_ = static_cast<SpdyMajorVersion>(GetParam());
32 } 32 }
33 33
34 // Version of SPDY protocol to be used. 34 // Version of SPDY protocol to be used.
35 SpdyMajorVersion spdy_version_; 35 SpdyMajorVersion spdy_version_;
36 }; 36 };
37 37
38 // All tests are run with two different SPDY versions: SPDY/2 and SPDY/3. 38 // All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.
39 INSTANTIATE_TEST_CASE_P(SpdyProtocolTests, 39 INSTANTIATE_TEST_CASE_P(SpdyProtocolTests,
40 SpdyProtocolTest, 40 SpdyProtocolTest,
(...skipping 12 matching lines...) Expand all
53 EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, 0xFFFFFFFF)), 53 EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, 0xFFFFFFFF)),
54 "SPDY setting ID too large."); 54 "SPDY setting ID too large.");
55 // Make sure that we get expected values in opt mode. 55 // Make sure that we get expected values in opt mode.
56 if (flags_and_id.get() != NULL) { 56 if (flags_and_id.get() != NULL) {
57 EXPECT_EQ(1, flags_and_id->flags()); 57 EXPECT_EQ(1, flags_and_id->flags());
58 EXPECT_EQ(static_cast<SpdyPingId>(0xffffff), flags_and_id->id()); 58 EXPECT_EQ(static_cast<SpdyPingId>(0xffffff), flags_and_id->id());
59 } 59 }
60 } 60 }
61 61
62 } // namespace net 62 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_network_transaction_unittest.cc ('k') | net/spdy/spdy_proxy_client_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698