Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Side by Side Diff: net/base/trace_net_log_observer_unittest.cc

Issue 663043004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/base/sdch_manager_unittest.cc ('k') | net/base/upload_bytes_element_reader_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/trace_net_log_observer.h" 5 #include "net/base/trace_net_log_observer.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 public: 53 public:
54 TraceNetLogObserverTest() { 54 TraceNetLogObserverTest() {
55 TraceLog* tracelog = TraceLog::GetInstance(); 55 TraceLog* tracelog = TraceLog::GetInstance();
56 DCHECK(tracelog); 56 DCHECK(tracelog);
57 DCHECK(!tracelog->IsEnabled()); 57 DCHECK(!tracelog->IsEnabled());
58 trace_buffer_.SetOutputCallback(json_output_.GetCallback()); 58 trace_buffer_.SetOutputCallback(json_output_.GetCallback());
59 trace_net_log_observer_.reset(new TraceNetLogObserver()); 59 trace_net_log_observer_.reset(new TraceNetLogObserver());
60 trace_events_.reset(new base::ListValue()); 60 trace_events_.reset(new base::ListValue());
61 } 61 }
62 62
63 virtual ~TraceNetLogObserverTest() { 63 ~TraceNetLogObserverTest() override {
64 DCHECK(!TraceLog::GetInstance()->IsEnabled()); 64 DCHECK(!TraceLog::GetInstance()->IsEnabled());
65 } 65 }
66 66
67 void OnTraceDataCollected( 67 void OnTraceDataCollected(
68 base::RunLoop* run_loop, 68 base::RunLoop* run_loop,
69 const scoped_refptr<base::RefCountedString>& events_str, 69 const scoped_refptr<base::RefCountedString>& events_str,
70 bool has_more_events) { 70 bool has_more_events) {
71 DCHECK(trace_events_->empty()); 71 DCHECK(trace_events_->empty());
72 trace_buffer_.Start(); 72 trace_buffer_.Start();
73 trace_buffer_.AddFragment(events_str->data()); 73 trace_buffer_.AddFragment(events_str->data());
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 EXPECT_TRUE(item1->GetString("args.params.foo", &item1_params)); 369 EXPECT_TRUE(item1->GetString("args.params.foo", &item1_params));
370 EXPECT_EQ("bar", item1_params); 370 EXPECT_EQ("bar", item1_params);
371 371
372 EXPECT_TRUE(item2->GetString("args.params", &item2_params)); 372 EXPECT_TRUE(item2->GetString("args.params", &item2_params));
373 EXPECT_TRUE(item2_params.empty()); 373 EXPECT_TRUE(item2_params.empty());
374 } 374 }
375 375
376 } // namespace 376 } // namespace
377 377
378 } // namespace net 378 } // namespace net
OLDNEW
« no previous file with comments | « net/base/sdch_manager_unittest.cc ('k') | net/base/upload_bytes_element_reader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698