Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 663023007: Include high-fidelity metadata about a download in incident reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: robert comments (and sync to r300494, oops) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index a232dc717ef7d174cbb14241e9522ad306f691d5..68471b08da82336c70d60d82b42c54b9a9a3b181 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -280,8 +280,8 @@ void SafeBrowsingService::ShutDown() {
// dtor executes now since it may call the dtor of URLFetcher which relies
// on it.
csd_service_.reset();
- download_service_.reset();
incident_service_.reset();
+ download_service_.reset();
url_request_context_getter_ = NULL;
BrowserThread::PostNonNestableTask(
@@ -347,6 +347,14 @@ void SafeBrowsingService::RegisterDelayedAnalysisCallback(
#endif
}
+void SafeBrowsingService::AddDownloadManager(
+ content::DownloadManager* download_manager) {
+#if defined(FULL_SAFE_BROWSING)
+ if (incident_service_)
+ incident_service_->AddDownloadManager(download_manager);
+#endif
+}
+
SafeBrowsingUIManager* SafeBrowsingService::CreateUIManager() {
return new SafeBrowsingUIManager(this);
}

Powered by Google App Engine
This is Rietveld 408576698