tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d0385d636d9d6f5bef982c0ed17d12e0366660e5..3512de17dd1cdcc803e1b0fd4a540c2b95c9c39c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -29409,6 +29409,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="SBIRS.DownloadMetadataDeleteSuccess" enum="BooleanSuccess">

[Alexei Svitkine (slow), 2014/10/27 17:09:07]

Nit: I suggest naming these histograms with an intermediate "." in the name, so
there's better grouping on the dashboard.

My suggestion for the names:

SBIRS.DownloadMetadata.DeleteSuccess
SBIRS.DownloadMetadata.ReadResult
SBIRS.DownloadMetadata.WriteResult

Change here and in the code.

[grt (UTC plus 2), 2014/10/30 15:11:40]

Done.

+  <owner>grt@chromium.org</owner>
+  <summary>The result of deleting a profile's download metadata file.</summary>
+</histogram>
+
+<histogram name="SBIRS.DownloadMetadataReadResult" enum="MetadataReadResult">
+  <owner>grt@chromium.org</owner>
+  <summary>The result of reading a profile's download metadata file.</summary>
+</histogram>
+
+<histogram name="SBIRS.DownloadMetadataWriteResult" enum="MetadataWriteResult">
+  <owner>grt@chromium.org</owner>
+  <summary>The result of writing a profile's download metadata file.</summary>
+</histogram>
+
 <histogram name="SBIRS.DroppedIncident" enum="IncidentType">
   <owner>grt@google.com</owner>
   <summary>
@@ -47612,6 +47627,23 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="1" label="Http Live Stream Type"/>
 </enum>
 
+<enum name="MetadataReadResult" type="int">
+  <int value="0" label="Success"/>
+  <int value="1" label="Open failure"/>
+  <int value="2" label="Not found"/>
+  <int value="3" label="Get info failure"/>
+  <int value="4" label="File too big"/>
+  <int value="5" label="Read failure"/>
+  <int value="6" label="Parse failure"/>
+  <int value="7" label="Malformed data"/>
+</enum>
+
+<enum name="MetadataWriteResult" type="int">
+  <int value="0" label="Success"/>
+  <int value="1" label="Serialization failure"/>
+  <int value="2" label="Write failure"/>
+</enum>
+
 <enum name="MetaTagTypeEnum" type="int">
   <int value="0" label="No viewport tag"/>
   <int value="1" label="Viewport meta with device width"/>