Mojo: mojob.sh: Make --release (etc.) work properly again.

mojo/tools/mojob.sh

 #!/bin/bash
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This a simple script to make building/testing Mojo components easier (on
 # Linux).
 
 # TODO(vtl): Maybe make the test runner smart and not run unchanged test
 # binaries.
@@ skipping 83 matching lines @@
 should_do_Release() {
   test "$BUILD_TYPE" = Release -o "$BUILD_TYPE" = Debug_and_Release
 }
 
 # Valid values: clang or gcc.
 COMPILER=clang
 # Valid values: auto or disabled.
 GOMA=auto
 make_gn_args() {
   local args=()
+  # TODO(vtl): It's a bit of a hack to infer the build type from the output
+  # directory name, but it's what we have right now (since we support "debug and
+  # release" mode).
+  case "$1" in
+    Debug)

[jamesr, 2014/10/21 00:46:35]

i would leave this out - is_debug=true is the default, no need to pollute args

[viettrungluu, 2014/10/21 01:04:22]

My thinking is that if you make an explicit choice (e.g., debug vs release),
then you should put in the arg, since defaults are subject to change (and this
would silently start to do the wrong thing).

(An alternative is to compare the value vs the default and set it only if it's
not the default, but that's a lot of work.)

+      args+=("is_debug=true")
+      ;;
+    Release)
+      args+=("is_debug=false")
+      ;;
+  esac
   case "$COMPILER" in
     clang)
       args+=("is_clang=true")
       ;;
     gcc)
       args+=("is_clang=false")
       ;;
   esac
   case "$GOMA" in
     auto)
@@ skipping 82 matching lines @@
       GOMA=disabled
       ;;
     *)
       echo "Unknown command \"${arg}\". Try \"$(basename "$0") help\"."
       exit 1
       ;;
   esac
 done
 
 exit 0