Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 663023003: Avoid subtree style recalc for fullscreen pseudos. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 1 month ago
Reviewers:
chrishtr, esprehn, dglazkov
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid subtree style recalc for fullscreen pseudos. Do not let the presence of any of the following pseudo classes require a sub-tree style recalc: :-webkit-full-screen :-webkit-full-screen-ancestor :-webkit-full-screen-document R=chrishtr@chromium.org,esprehn@chromium.org BUG=425070 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184441

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -3 lines) Patch
A LayoutTests/fast/css/invalidation/fullscreen.html View 1 chunk +74 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/fullscreen-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
6 years, 2 months ago (2014-10-20 12:15:53 UTC) #1
rune
PTAL
6 years, 2 months ago (2014-10-24 08:46:10 UTC) #2
dglazkov
lgtm
6 years, 2 months ago (2014-10-24 15:03:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663023003/1
6 years, 2 months ago (2014-10-24 15:04:12 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/css/RuleFeature.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-24 15:04:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663023003/20001
6 years, 1 month ago (2014-10-27 10:58:27 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 11:59:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184441

Powered by Google App Engine
This is Rietveld 408576698