Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 663013004: [ew] Mark APIs being in developement as nodoc. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ew] Mark APIs being in developement as nodoc. Since the features are not ready, information about the new API should not be published on the official documentation. TEST=Tested manually with a preview server. BUG=425924 Committed: https://crrev.com/df17802a065102ff635313baf8586df83d9e1799 Cr-Commit-Position: refs/heads/master@{#301069}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/common/extensions/api/file_system.idl View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mtomasz
@benwells: PTAL. Thanks.
6 years, 2 months ago (2014-10-24 04:04:31 UTC) #2
benwells
https://codereview.chromium.org/663013004/diff/1/chrome/common/extensions/api/file_system.idl File chrome/common/extensions/api/file_system.idl (right): https://codereview.chromium.org/663013004/diff/1/chrome/common/extensions/api/file_system.idl#newcode62 chrome/common/extensions/api/file_system.idl:62: [nodoc] dictionary ChooseEntryOptions { I think this one shouldn't ...
6 years, 2 months ago (2014-10-24 05:34:51 UTC) #3
mtomasz
https://codereview.chromium.org/663013004/diff/1/chrome/common/extensions/api/file_system.idl File chrome/common/extensions/api/file_system.idl (right): https://codereview.chromium.org/663013004/diff/1/chrome/common/extensions/api/file_system.idl#newcode62 chrome/common/extensions/api/file_system.idl:62: [nodoc] dictionary ChooseEntryOptions { On 2014/10/24 05:34:51, benwells wrote: ...
6 years, 2 months ago (2014-10-24 05:36:43 UTC) #4
benwells
lgtm
6 years, 2 months ago (2014-10-24 05:41:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663013004/20001
6 years, 2 months ago (2014-10-24 05:43:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-24 07:01:36 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 07:02:13 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df17802a065102ff635313baf8586df83d9e1799
Cr-Commit-Position: refs/heads/master@{#301069}

Powered by Google App Engine
This is Rietveld 408576698