Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 662973003: Add --root-layer-scrolls. (Closed)

Created:
6 years, 2 months ago by skobes
Modified:
6 years, 1 month ago
Reviewers:
Ian Vollick, jam
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add --root-layer-scrolls. BUG=417782 Committed: https://crrev.com/2eeec6853a1579d09754acfa9961e4dc36aa9264 Cr-Commit-Position: refs/heads/master@{#302588}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
skobes
6 years, 1 month ago (2014-10-31 00:03:54 UTC) #2
Ian Vollick
On 2014/10/31 00:03:54, skobes wrote: I think you might want to add the flag to ...
6 years, 1 month ago (2014-10-31 20:05:53 UTC) #3
skobes
On 2014/10/31 20:05:53, vollick wrote: > On 2014/10/31 00:03:54, skobes wrote: > > I think ...
6 years, 1 month ago (2014-11-03 23:54:27 UTC) #4
skobes
+jam for OWNERS
6 years, 1 month ago (2014-11-03 23:54:39 UTC) #6
Ian Vollick
On 2014/11/03 23:54:39, skobes wrote: > +jam for OWNERS lgtm
6 years, 1 month ago (2014-11-04 00:42:48 UTC) #7
jam
lgtm
6 years, 1 month ago (2014-11-04 06:58:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662973003/20001
6 years, 1 month ago (2014-11-04 07:19:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 08:13:52 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2eeec6853a1579d09754acfa9961e4dc36aa9264 Cr-Commit-Position: refs/heads/master@{#302588}
6 years, 1 month ago (2014-11-04 08:14:31 UTC) #12
tzik
6 years, 1 month ago (2014-11-04 08:41:57 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/695613005/ by tzik@chromium.org.

The reason for reverting is: This CL causes build failure:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C...

The error log is:
FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ (snip) -o
interactive_ui_tests (snip)
obj/chrome/libbrowser_chromeos.a(obj/chrome/browser/chromeos/login/browser_chromeos.chrome_restart_request.o):../../chrome/browser/chromeos/login/chrome_restart_request.cc:chromeos::(anonymous
namespace)::DeriveCommandLine(GURL const&, base::CommandLine const&,
base::DictionaryValue const&, base::CommandLine*)::kForwardSwitches:error:
undefined reference to 'switches::kRootLayerScrolls'
clang:error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
.

Powered by Google App Engine
This is Rietveld 408576698