Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 662963002: Revert of Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (Closed)

Created:
6 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
nednguyen, hendrikw, dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #1 id:1 of https://codereview.chromium.org/661303002/) Reason for revert: The removal of Telemetry's retry logic wasn't the cause of the intermittent crashes on the GPU bots. Original issue's description: > Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/) > > Reason for revert: > Possible cause of gpu telemetry bot flake > > Original issue's description: > > [Telemetry] Set the number of attempts to retry a test to 1 > > > > **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted. > > > > BUG=422339 > > > > Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03 > > Cr-Commit-Position: refs/heads/master@{#299716} > > TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com > NOTREECHECKS=true > NOTRY=true > BUG=422339 > > Committed: https://crrev.com/1c141bedc45cdef1ac7b7264ea1288c33e33d106 > Cr-Commit-Position: refs/heads/master@{#300218} TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,hendrikw@chromium.org NOTREECHECKS=true NOTRY=true BUG=422339 Committed: https://crrev.com/89b463ddd92b4c9abe7898506ccb4935cef75d1e Cr-Commit-Position: refs/heads/master@{#300225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 2 months ago (2014-10-19 14:30:43 UTC) #1
Created Revert of Revert of [Telemetry] Set the number of attempts to retry a
test if browser or tab crash to 1

Powered by Google App Engine
This is Rietveld 408576698