Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 66293006: GTTF: Test launcher - correctly handle non-zero exit code with all tests passing (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.
Modified:
7 years, 1 month ago
Reviewers:
earthdok
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GTTF: Test launcher - correctly handle non-zero exit code with all tests passing BUG=317752 R=earthdok@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -24 lines) Patch
M base/test/launcher/test_result.h View 2 chunks +10 lines, -7 lines 0 comments Download
M base/test/launcher/test_result.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/test/launcher/test_results_tracker.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 7 chunks +62 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-11 19:41:20 UTC) #1
earthdok
lgtm
7 years, 1 month ago (2013-11-11 20:02:23 UTC) #2
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-12 00:09:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r234338 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698