Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 662913002: Fire accessible event on web area object when scrolling (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
aboxhall
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@scroll_again
Project:
blink
Visibility:
Public.

Description

Fire accessible event on web area object when scrolling Scroll events for the main document were accidentally removed in bug 371039 - this is a better way to restore them by firing them on the web area, rather than the ScrollView/FrameView. This brings back the "scroll" sounds on Android, and also makes Android update the position of accessibility focus after scrolling. BUG=371039, 374316, 414291 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184002

Patch Set 1 #

Patch Set 2 : Update tests based on change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M LayoutTests/accessibility/scroll-window-horiz-sends-notification.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/accessibility/scroll-window-horiz-sends-notification-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/scroll-window-sends-notification.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/accessibility/scroll-window-sends-notification-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dmazzoni
6 years, 2 months ago (2014-10-17 23:07:59 UTC) #2
aboxhall
lgtm
6 years, 2 months ago (2014-10-20 15:10:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662913002/1
6 years, 2 months ago (2014-10-20 15:26:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29990)
6 years, 2 months ago (2014-10-20 16:24:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662913002/20001
6 years, 2 months ago (2014-10-20 17:38:28 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 18:52:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184002

Powered by Google App Engine
This is Rietveld 408576698