Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 662893002: Use proper integer constants instead of enums (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
Reviewers:
tdresser
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bug424334
Project:
chromium
Visibility:
Public.

Description

Use proper integer constants instead of enums -Wtype-limits will throw warnings if an enum is used interchangably with an integer. Replace some such usages with proper integer constants. BUG=424334 TEST=build, unit test Committed: https://crrev.com/2f82d4c8406b739fe35252357b32aadd56ab08f3 Cr-Commit-Position: refs/heads/master@{#300376}

Patch Set 1 #

Patch Set 2 : Fix windows compile #

Total comments: 2

Patch Set 3 : Re-add DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M ui/events/gesture_detection/velocity_tracker.cc View 1 2 12 chunks +23 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tdresser
https://codereview.chromium.org/662893002/diff/20001/ui/events/gesture_detection/velocity_tracker.cc File ui/events/gesture_detection/velocity_tracker.cc (left): https://codereview.chromium.org/662893002/diff/20001/ui/events/gesture_detection/velocity_tracker.cc#oldcode476 ui/events/gesture_detection/velocity_tracker.cc:476: DCHECK_LE(m, static_cast<uint32_t>(M_ARRAY_LENGTH)); These DCHECKs are still relevant, aren't they?
6 years, 2 months ago (2014-10-20 14:27:31 UTC) #2
Chris Masone
https://codereview.chromium.org/662893002/diff/20001/ui/events/gesture_detection/velocity_tracker.cc File ui/events/gesture_detection/velocity_tracker.cc (left): https://codereview.chromium.org/662893002/diff/20001/ui/events/gesture_detection/velocity_tracker.cc#oldcode476 ui/events/gesture_detection/velocity_tracker.cc:476: DCHECK_LE(m, static_cast<uint32_t>(M_ARRAY_LENGTH)); On 2014/10/20 14:27:31, tdresser wrote: > These ...
6 years, 2 months ago (2014-10-20 16:05:22 UTC) #3
tdresser
LGTM
6 years, 2 months ago (2014-10-20 16:28:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662893002/40001
6 years, 2 months ago (2014-10-20 22:44:45 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-20 23:39:56 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 23:40:46 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2f82d4c8406b739fe35252357b32aadd56ab08f3
Cr-Commit-Position: refs/heads/master@{#300376}

Powered by Google App Engine
This is Rietveld 408576698