content/renderer/media/renderer_webmidiaccessor_impl.cc - Issue 662853003: Manage MIDI related objects and sessions' lifecycles correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_webmidiaccessor_impl.cc

Issue 662853003: Manage MIDI related objects and sessions' lifecycles correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unittest Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/renderer_webmidiaccessor_impl.cc

diff --git a/content/renderer/media/renderer_webmidiaccessor_impl.cc b/content/renderer/media/renderer_webmidiaccessor_impl.cc

index 75b6b972005adfe37a43107da2dbdc59b5e39424..b67f48a7ae69447c6a1c2ed6949764081fa60979 100644

--- a/content/renderer/media/renderer_webmidiaccessor_impl.cc

+++ b/content/renderer/media/renderer_webmidiaccessor_impl.cc

@@ -21,7 +21,7 @@ RendererWebMIDIAccessorImpl::~RendererWebMIDIAccessorImpl() {

}

void RendererWebMIDIAccessorImpl::startSession() {

- midi_message_filter()->StartSession(client_);

+ midi_message_filter()->AddClient(client_);

}

void RendererWebMIDIAccessorImpl::sendMIDIData(

« content/renderer/media/midi_message_filter.cc ('K') | « content/renderer/media/midi_message_filter.cc ('k') | media/midi/midi_manager.h » ('j') | media/midi/midi_manager.cc » ('J')