content/common/media/midi_messages.h - Issue 662853003: Manage MIDI related objects and sessions' lifecycles correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/midi_messages.h

Issue 662853003: Manage MIDI related objects and sessions' lifecycles correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unittest Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/midi_host.cc ('K') | « content/browser/media/midi_host.cc ('k') | content/renderer/media/midi_message_filter.h » ('j') | content/renderer/media/midi_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/media/midi_messages.h

diff --git a/content/common/media/midi_messages.h b/content/common/media/midi_messages.h

index da131397e64781291026106178532b16612fc78b..c1375c3d4be2b6c2935908bab7324b5d67453faf 100644

--- a/content/common/media/midi_messages.h

+++ b/content/common/media/midi_messages.h

@@ -43,18 +43,18 @@ IPC_MESSAGE_ROUTED2(MidiMsg_SysExPermissionApproved,

// Messages for IPC between MidiMessageFilter and MidiHost.

// Renderer request to browser for access to MIDI services.

-IPC_MESSAGE_CONTROL1(MidiHostMsg_StartSession,

- int /* client id */)

+IPC_MESSAGE_CONTROL0(MidiHostMsg_StartSession)

IPC_MESSAGE_CONTROL3(MidiHostMsg_SendData,

uint32 /* port */,

std::vector<uint8> /* data */,

double /* timestamp */)

+IPC_MESSAGE_CONTROL0(MidiHostMsg_EndSession)

// Messages sent from the browser to the renderer.

-IPC_MESSAGE_CONTROL4(MidiMsg_SessionStarted,

- int /* client id */,

+IPC_MESSAGE_CONTROL3(MidiMsg_SessionStarted,

media::MidiResult /* result */,

media::MidiPortInfoList /* input ports */,

media::MidiPortInfoList /* output ports */)