Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: media/midi/midi_manager_usb_unittest.cc

Issue 662853003: Manage MIDI related objects and sessions' lifecycles correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments at #7 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/midi/midi_manager_usb_unittest.cc
diff --git a/media/midi/midi_manager_usb_unittest.cc b/media/midi/midi_manager_usb_unittest.cc
index b162eed0bcdfe7bd9d83f2e841dadcbb78786cef..0e5a3b55391511431e51c24b33c6390c973e96fa 100644
--- a/media/midi/midi_manager_usb_unittest.cc
+++ b/media/midi/midi_manager_usb_unittest.cc
@@ -79,7 +79,7 @@ class FakeMidiManagerClient : public MidiManagerClient {
logger_(logger) {}
virtual ~FakeMidiManagerClient() {}
- virtual void CompleteStartSession(int client_id, MidiResult result) override {
+ virtual void CompleteStartSession(MidiResult result) override {
complete_start_session_ = true;
result_ = result;
}
@@ -160,7 +160,7 @@ class MidiManagerUsbTest : public ::testing::Test {
protected:
void Initialize() {
client_.reset(new FakeMidiManagerClient(&logger_));
- manager_->StartSession(client_.get(), 0);
+ manager_->StartSession(client_.get());
}
void Finalize() {

Powered by Google App Engine
This is Rietveld 408576698