chrome/renderer/searchbox/searchbox_extension.cc - Issue 662823002: Fix incorrect IPC_ENUM_TRAITS_MAX_VALUE for NTPLoggingEventType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 662823002: Fix incorrect IPC_ENUM_TRAITS_MAX_VALUE for NTPLoggingEventType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/split-enum

Patch Set: Rename to NTP_EVENT_TYPE_LAST Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/searchbox/searchbox_extension.cc

diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc

index 865f097128eba1c97adc1ebac3541001dc4d93fd..2133621c4147a948fa9c18a601ae6db9f76f1705 100644

--- a/chrome/renderer/searchbox/searchbox_extension.cc

+++ b/chrome/renderer/searchbox/searchbox_extension.cc

@@ -971,7 +971,7 @@ void SearchBoxExtensionWrapper::LogEvent(

DVLOG(1) << render_view << " LogEvent";

- if (args[0]->Uint32Value() < NTP_NUM_EVENT_TYPES) {

+ if (args[0]->Uint32Value() <= NTP_EVENT_TYPE_LAST) {

NTPLoggingEventType event =

static_cast<NTPLoggingEventType>(args[0]->Uint32Value());

SearchBox::Get(render_view)->LogEvent(event);

« no previous file with comments | « chrome/common/render_messages.h ('k') | no next file » | no next file with comments »