Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 662813003: include "util/stdlib/cxx.h" before checking CXX_LIBRARY_VERSION (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad/+/master
Project:
crashpad
Visibility:
Public.

Description

include "util/stdlib/cxx.h" before checking CXX_LIBRARY_VERSION. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7d84d6512be3377d1b90a534a7eed35716b461ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M client/crashpad_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-17 18:03:23 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-17 18:04:30 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-17 18:24:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d84d6512be3377d1b90a534a7eed35716b461ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698