Issue 662813002: IA: Double arithmetic binops support memory operand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 662813002: IA: Double arithmetic binops support memory operand (Closed)

Created:
6 years, 2 months ago by Weiliang

Modified:
6 years, 1 month ago

Reviewers:
Benedikt Meurer, titzer, dcarney, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

IA: Double arithmetic binops support memory operand BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25052

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -63 lines)			Patch
M	src/compiler/ia32/code-generator-ia32.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/compiler/x64/code-generator-x64.cc	View	2 chunks	+15 lines, -9 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	5 chunks	+1 line, -37 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/cctest/test-disasm-x64.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Weiliang

PTAL Seems asm.js leads to higher double register pressure.

6 years, 2 months ago (2014-10-17 13:49:18 UTC) #2

Benedikt Meurer

6 years, 1 month ago (2014-11-03 05:57:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25052 (presubmit successful).