Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 662803002: Fix includes in //components/keyed_service/content (Closed)

Created:
6 years, 2 months ago by sdefresne
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Fix includes in //components/keyed_service/content Remove unnecessary includes for forward-declared classes in both refcounted_browser_context_keyed_service_factory.h and browser_context_keyed_service_factory.h. Fix other header files broken by this cleanup by addding the missing include. BUG=419366 TBR=jochen@chromium.org Committed: https://crrev.com/997d364ad30fe99c15c8246e2c638e9e55d7e8ad Cr-Commit-Position: refs/heads/master@{#300250}

Patch Set 1 #

Patch Set 2 : Fix compilation on !Linux #

Messages

Total messages: 8 (3 generated)
sdefresne
phajdan.jr: please take a look at this cleanup CL. jochen: adding you as OWNERS of ...
6 years, 2 months ago (2014-10-17 12:27:14 UTC) #3
Paweł Hajdan Jr.
LGTM
6 years, 2 months ago (2014-10-17 17:23:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662803002/20001
6 years, 2 months ago (2014-10-20 12:02:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 12:22:17 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 12:23:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/997d364ad30fe99c15c8246e2c638e9e55d7e8ad
Cr-Commit-Position: refs/heads/master@{#300250}

Powered by Google App Engine
This is Rietveld 408576698