Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: dm-bht.c

Issue 6628022: CHROMIUM: verity: remove stale code/comments from earlier bitmap design (Closed) Base URL: http://git.chromium.org/git/dm-verity.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm-bht.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm-bht.c
diff --git a/dm-bht.c b/dm-bht.c
index c1c2d19c7e5bafcf0cea5b99b541ba95a2cddc8c..4ac06fa9d7907f3c2555050389e714df1ab572a7 100644
--- a/dm-bht.c
+++ b/dm-bht.c
@@ -288,15 +288,6 @@ int dm_bht_create(struct dm_bht *bht, unsigned int depth,
*/
bht->node_count = 1 << bht->node_count_shift;
- /* TODO(wad) if node_count < DM_BHT_MAX_NODE_COUNT, then retry with
- * node_count_shift-1.
- */
- if (bht->node_count > DM_BHT_MAX_NODE_COUNT) {
- DMERR("node_count maximum node bitmap size");
- status = -EINVAL;
- goto bad_node_count;
- }
-
/* This is unlikely to happen, but with 64k pages, who knows. */
if (bht->node_count > UINT_MAX / bht->digest_size) {
DMERR("node_count * hash_len exceeds UINT_MAX!");
@@ -634,7 +625,6 @@ static int dm_bht_check_block(struct dm_bht *bht, unsigned int block_index,
dm_bht_log_mismatch(bht, &entry->nodes[index], digest);
return DM_BHT_ENTRY_ERROR_MISMATCH;
}
- /* TODO(wad) update bht->block_bitmap here or in the caller */
return 0;
}
« no previous file with comments | « dm-bht.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698