Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: Source/devtools/front_end/ui/SettingsUI.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ui/SettingsUI.js
diff --git a/Source/devtools/front_end/ui/SettingsUI.js b/Source/devtools/front_end/ui/SettingsUI.js
index cce906c5f160226e486b3dcf6317089ca368052a..bb8b49bd9b5014ae704ed4a645fc05ab8cabcd7d 100644
--- a/Source/devtools/front_end/ui/SettingsUI.js
+++ b/Source/devtools/front_end/ui/SettingsUI.js
@@ -40,12 +40,12 @@ WebInspector.SettingsUI = {}
*/
WebInspector.SettingsUI.createSettingCheckbox = function(name, setting, omitParagraphElement, inputElement, tooltip)
{
- var input = inputElement || document.createElement("input");
+ var input = inputElement || createElement("input");
input.type = "checkbox";
input.name = name;
WebInspector.SettingsUI.bindCheckbox(input, setting);
- var label = document.createElement("label");
+ var label = createElement("label");
label.appendChild(input);
label.createTextChild(name);
if (tooltip)
@@ -54,7 +54,7 @@ WebInspector.SettingsUI.createSettingCheckbox = function(name, setting, omitPara
if (omitParagraphElement)
return label;
- var p = document.createElement("p");
+ var p = createElement("p");
p.appendChild(label);
return p;
}
@@ -95,7 +95,7 @@ WebInspector.SettingsUI.bindCheckbox = function(input, setting)
*/
WebInspector.SettingsUI.createSettingInputField = function(label, setting, numeric, maxLength, width, validatorCallback, instant, clearForZero, placeholder)
{
- var p = document.createElement("p");
+ var p = createElement("p");
var labelElement = p.createChild("label");
labelElement.textContent = label;
var inputElement = p.createChild("input");
@@ -207,7 +207,7 @@ WebInspector.SettingsUI.createSettingInputField = function(label, setting, numer
*/
WebInspector.SettingsUI.createCustomSetting = function(name, element)
{
- var p = document.createElement("p");
+ var p = createElement("p");
var fieldsetElement = p.createChild("fieldset");
fieldsetElement.createChild("label").textContent = name;
fieldsetElement.appendChild(element);
@@ -220,7 +220,7 @@ WebInspector.SettingsUI.createCustomSetting = function(name, element)
*/
WebInspector.SettingsUI.createSettingFieldset = function(setting)
{
- var fieldset = document.createElement("fieldset");
+ var fieldset = createElement("fieldset");
fieldset.disabled = !setting.get();
setting.addChangeListener(settingChanged);
return fieldset;
« no previous file with comments | « Source/devtools/front_end/ui/ProgressIndicator.js ('k') | Source/devtools/front_end/ui/ShowMoreDataGridNode.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698