Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: Source/devtools/front_end/toolbox/OverridesUI.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/toolbox/MediaQueryInspector.js ('k') | Source/devtools/front_end/ui/Checkbox.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/toolbox/OverridesUI.js
diff --git a/Source/devtools/front_end/toolbox/OverridesUI.js b/Source/devtools/front_end/toolbox/OverridesUI.js
index 6bc4f8dc3a5868308ffb3ea6172f1b7134c97ae1..1e3cb2862fd36e9f99701a149629b6440d8d0a18 100644
--- a/Source/devtools/front_end/toolbox/OverridesUI.js
+++ b/Source/devtools/front_end/toolbox/OverridesUI.js
@@ -11,7 +11,7 @@ WebInspector.OverridesUI = {}
*/
WebInspector.OverridesUI.createDeviceSelect = function(document, titleProvider)
{
- var p = document.createElement("p");
+ var p = createElement("p");
var deviceSelectElement = p.createChild("select");
deviceSelectElement.addEventListener("change", deviceSelected, false);
@@ -160,7 +160,7 @@ WebInspector.OverridesUI.createDeviceSelect = function(document, titleProvider)
WebInspector.OverridesUI.createNetworkConditionsSelect = function(document)
{
var networkConditionsSetting = WebInspector.overridesSupport.settings.networkConditions;
- var conditionsSelectElement = document.createElement("select");
+ var conditionsSelectElement = createElement("select");
var presets = WebInspector.OverridesUI._networkConditionsPresets;
for (var i = 0; i < presets.length; ++i) {
var preset = presets[i];
@@ -229,12 +229,12 @@ WebInspector.OverridesUI.createUserAgentSelectAndInput = function(document)
const customOverride = {title: WebInspector.UIString("Other"), value: "Other"};
var userAgents = [noOverride].concat(WebInspector.OverridesUI._userAgents).concat([customOverride]);
- var userAgentSelectElement = document.createElement("select");
+ var userAgentSelectElement = createElement("select");
for (var i = 0; i < userAgents.length; ++i)
userAgentSelectElement.add(new Option(userAgents[i].title, userAgents[i].value));
userAgentSelectElement.selectedIndex = 0;
- var otherUserAgentElement = document.createElement("input");
+ var otherUserAgentElement = createElement("input");
otherUserAgentElement.type = "text";
otherUserAgentElement.value = userAgentSetting.get();
otherUserAgentElement.title = userAgentSetting.get();
« no previous file with comments | « Source/devtools/front_end/toolbox/MediaQueryInspector.js ('k') | Source/devtools/front_end/ui/Checkbox.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698