Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js b/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js
index f4298c3594f6bf0ebd8389aee40b659b0355ff37..aa303aaef4be171203d009904e8be47f8c59336b 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js
@@ -391,7 +391,7 @@ WebInspector.TimelineUIUtilsImpl.buildDetailsNode = function(record, linkifier)
}
if (!details && detailsText)
- details = document.createTextNode(detailsText);
+ details = createTextNode(detailsText);
return details;
/**
@@ -496,7 +496,7 @@ WebInspector.TimelineUIUtilsImpl.generateDetailsContent = function(record, model
*/
WebInspector.TimelineUIUtilsImpl._generateDetailsContentSynchronously = function(record, model, linkifier, imagePreviewElement, relatedNode)
{
- var fragment = document.createDocumentFragment();
+ var fragment = createDocumentFragment();
var aggregatedStats = {};
WebInspector.TimelineUIUtilsImpl.aggregateTimeForRecord(aggregatedStats, record);
if (record.children().length)
@@ -643,7 +643,7 @@ WebInspector.TimelineUIUtilsImpl._generateDetailsContentSynchronously = function
contentHelper.appendStackTrace(callStackLabel || WebInspector.UIString("Call Stack"), recordStackTrace);
if (record.warnings()) {
- var ul = document.createElement("ul");
+ var ul = createElement("ul");
for (var i = 0; i < record.warnings().length; ++i)
ul.createChild("li").textContent = record.warnings()[i];
contentHelper.appendElementRow(WebInspector.UIString("Warning"), ul);
@@ -659,7 +659,7 @@ WebInspector.TimelineUIUtilsImpl._generateDetailsContentSynchronously = function
*/
WebInspector.TimelineUIUtilsImpl._createEventDivider = function(recordType, title)
{
- var eventDivider = document.createElement("div");
+ var eventDivider = createElement("div");
eventDivider.className = "resources-event-divider";
var recordTypes = WebInspector.TimelineModel.RecordType;
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | Source/devtools/front_end/timeline/TimelineView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698