Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: Source/devtools/front_end/main/OverridesView.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/main/OverridesView.js
diff --git a/Source/devtools/front_end/main/OverridesView.js b/Source/devtools/front_end/main/OverridesView.js
index 469f092d908a5afb067de1b8c44cfb226b6a5310..17bc7a6f5959727ffde354ad3551a5d34e94f8c4 100644
--- a/Source/devtools/front_end/main/OverridesView.js
+++ b/Source/devtools/front_end/main/OverridesView.js
@@ -209,7 +209,7 @@ WebInspector.OverridesView.DeviceTab = function()
WebInspector.OverridesView.DeviceTab.prototype = {
_createDeviceElement: function()
{
- var fieldsetElement = document.createElement("fieldset");
+ var fieldsetElement = createElement("fieldset");
fieldsetElement.id = "metrics-override-section";
var deviceModelElement = fieldsetElement.createChild("p", "overrides-device-model-section");
@@ -280,7 +280,7 @@ WebInspector.OverridesView.DeviceTab.CustomDeviceTitleDialog = function(callback
{
WebInspector.DialogDelegate.call(this);
- this.element = document.createElementWithClass("div", "custom-device-title-dialog");
+ this.element = createElementWithClass("div", "custom-device-title-dialog");
this.element.createChild("label").textContent = WebInspector.UIString("Save as: ");
this._input = this.element.createChild("input");
@@ -362,7 +362,7 @@ WebInspector.OverridesView.MediaTab.prototype = {
// "all" is not a device-specific media type.
continue;
}
- var option = document.createElement("option");
+ var option = createElement("option");
option.text = mediaType;
option.value = mediaType;
mediaSelectElement.add(option);
@@ -371,7 +371,7 @@ WebInspector.OverridesView.MediaTab.prototype = {
}
mediaSelectElement.addEventListener("change", this._emulateMediaChanged.bind(this, mediaSelectElement), false);
- var fragment = document.createDocumentFragment();
+ var fragment = createDocumentFragment();
fragment.appendChild(checkbox);
fragment.appendChild(fieldsetElement);
this.element.appendChild(fragment);
@@ -523,7 +523,7 @@ WebInspector.OverridesView.SensorsTab.prototype = {
rowElement = tableElement.createChild("tr");
cellElement = rowElement.createChild("td");
cellElement.colSpan = 2;
- var geolocationErrorLabelElement = document.createElement("label");
+ var geolocationErrorLabelElement = createElement("label");
var geolocationErrorCheckboxElement = geolocationErrorLabelElement.createChild("input");
geolocationErrorCheckboxElement.id = "geolocation-error";
geolocationErrorCheckboxElement.type = "checkbox";
« no previous file with comments | « Source/devtools/front_end/layers/LayerTreeOutline.js ('k') | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698