Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1916)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/console/ConsoleView.js ('k') | Source/devtools/front_end/devices/DevicesView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index 50968de8b92b7d15813da12fe2e1993b230f89cf..0a82667c5fb006e5c5409f1d2eae70f704ccb6a3 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -126,7 +126,7 @@ WebInspector.ConsoleViewMessage.prototype = {
_formatMessage: function()
{
- this._formattedMessage = document.createElement("span");
+ this._formattedMessage = createElement("span");
this._formattedMessage.className = "console-message-text source-code";
/**
@@ -147,7 +147,7 @@ WebInspector.ConsoleViewMessage.prototype = {
this._messageElement = this._format(consoleMessage.parameters || ["console.trace()"]);
break;
case WebInspector.ConsoleMessage.MessageType.Clear:
- this._messageElement = document.createTextNode(WebInspector.UIString("Console was cleared"));
+ this._messageElement = createTextNode(WebInspector.UIString("Console was cleared"));
this._formattedMessage.classList.add("console-info");
break;
case WebInspector.ConsoleMessage.MessageType.Assert:
@@ -171,7 +171,7 @@ WebInspector.ConsoleViewMessage.prototype = {
}
} else if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network) {
if (consoleMessage.request) {
- this._messageElement = document.createElement("span");
+ this._messageElement = createElement("span");
if (consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error) {
this._messageElement.createTextChildren(consoleMessage.request.requestMethod, " ");
this._messageElement.appendChild(WebInspector.Linkifier.linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, consoleMessage.request.url));
@@ -212,13 +212,13 @@ WebInspector.ConsoleViewMessage.prototype = {
this._formattedMessage.appendChild(this._messageElement);
if (this._anchorElement) {
- this._formattedMessage.insertBefore(document.createTextNode(" "), this._formattedMessage.firstChild);
+ this._formattedMessage.insertBefore(createTextNode(" "), this._formattedMessage.firstChild);
this._formattedMessage.insertBefore(this._anchorElement, this._formattedMessage.firstChild);
}
var dumpStackTrace = !!consoleMessage.stackTrace && consoleMessage.stackTrace.length && (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace);
if (dumpStackTrace) {
- var ol = document.createElement("ol");
+ var ol = createElement("ol");
ol.className = "outline-disclosure";
var treeOutline = new TreeOutline(ol);
@@ -344,7 +344,7 @@ WebInspector.ConsoleViewMessage.prototype = {
_format: function(parameters)
{
// This node is used like a Builder. Values are continually appended onto it.
- var formattedResult = document.createElement("span");
+ var formattedResult = createElement("span");
if (!parameters.length)
return formattedResult;
@@ -408,7 +408,7 @@ WebInspector.ConsoleViewMessage.prototype = {
{
var type = forceObjectFormat ? "object" : (output.subtype || output.type);
var formatter = this._customFormatters[type] || this._formatParameterAsValue;
- var span = document.createElement("span");
+ var span = createElement("span");
span.className = "console-formatted-" + type + " source-code";
formatter.call(this, output, span, includePreview);
return span;
@@ -442,7 +442,7 @@ WebInspector.ConsoleViewMessage.prototype = {
*/
_formatParameterAsArrayOrObject: function(obj, elem, includePreview)
{
- var titleElement = document.createElement("span");
+ var titleElement = createElement("span");
if (includePreview && obj.preview) {
titleElement.classList.add("console-object-preview");
var lossless = this._appendObjectPreview(titleElement, obj.preview, obj);
@@ -572,7 +572,7 @@ WebInspector.ConsoleViewMessage.prototype = {
*/
_renderPropertyPreview: function(type, subtype, description)
{
- var span = document.createElementWithClass("span", "console-formatted-" + (subtype || type));
+ var span = createElementWithClass("span", "console-formatted-" + (subtype || type));
description = description || "";
if (type === "function") {
@@ -644,7 +644,7 @@ WebInspector.ConsoleViewMessage.prototype = {
*/
_formatParameterAsTable: function(parameters)
{
- var element = document.createElement("span");
+ var element = createElement("span");
var table = parameters[0];
if (!table || !table.preview)
return element;
@@ -709,7 +709,7 @@ WebInspector.ConsoleViewMessage.prototype = {
*/
_formatParameterAsString: function(output, elem)
{
- var span = document.createElement("span");
+ var span = createElement("span");
span.className = "console-formatted-string source-code";
span.appendChild(WebInspector.linkifyStringAsFragment(output.description || ""));
@@ -878,7 +878,7 @@ WebInspector.ConsoleViewMessage.prototype = {
function styleFormatter(obj)
{
currentStyle = {};
- var buffer = document.createElement("span");
+ var buffer = createElement("span");
buffer.setAttribute("style", obj.description);
for (var i = 0; i < buffer.style.length; i++) {
var property = buffer.style[i];
@@ -920,7 +920,7 @@ WebInspector.ConsoleViewMessage.prototype = {
else if (typeof b !== "undefined") {
var toAppend = WebInspector.linkifyStringAsFragment(String(b));
if (currentStyle) {
- var wrapper = document.createElement('span');
+ var wrapper = createElement('span');
for (var key in currentStyle)
wrapper.style[key] = currentStyle[key];
wrapper.appendChild(toAppend);
@@ -1042,7 +1042,7 @@ WebInspector.ConsoleViewMessage.prototype = {
if (this._element)
return this._element;
- var element = document.createElementWithClass("div", "console-message");
+ var element = createElementWithClass("div", "console-message");
this._element = element;
switch (this._message.level) {
@@ -1084,7 +1084,7 @@ WebInspector.ConsoleViewMessage.prototype = {
if (this._wrapperElement)
return this._wrapperElement;
- this._wrapperElement = document.createElementWithClass("div", "console-message-wrapper");
+ this._wrapperElement = createElementWithClass("div", "console-message-wrapper");
this._nestingLevelMarkers = [];
for (var i = 0; i < this._nestingLevel; ++i)
this._nestingLevelMarkers.push(this._wrapperElement.createChild("div", "nesting-level-marker"));
@@ -1112,7 +1112,7 @@ WebInspector.ConsoleViewMessage.prototype = {
for (var i = 0; i < stackTrace.length; i++) {
var frame = stackTrace[i];
- var content = document.createElementWithClass("div", "stacktrace-entry");
+ var content = createElementWithClass("div", "stacktrace-entry");
var functionName = frame.functionName || WebInspector.UIString("(anonymous function)");
if (frame.scriptId) {
var urlElement = this._linkifyCallFrame(frame);
@@ -1132,7 +1132,7 @@ WebInspector.ConsoleViewMessage.prototype = {
for (var asyncTrace = this._message.asyncStackTrace; asyncTrace; asyncTrace = asyncTrace.asyncStackTrace) {
if (!asyncTrace.callFrames || !asyncTrace.callFrames.length)
break;
- var content = document.createElementWithClass("div", "stacktrace-entry");
+ var content = createElementWithClass("div", "stacktrace-entry");
var description = WebInspector.asyncStackTraceLabel(asyncTrace.description);
content.createChild("span", "console-message-text source-code console-async-trace-text").textContent = description;
parentTreeElement.appendChild(new TreeElement(content));
@@ -1162,7 +1162,7 @@ WebInspector.ConsoleViewMessage.prototype = {
return;
if (!this._repeatCountElement) {
- this._repeatCountElement = document.createElement("span");
+ this._repeatCountElement = createElement("span");
this._repeatCountElement.className = "bubble-repeat-count";
this._element.insertBefore(this._repeatCountElement, this._element.firstChild);
« no previous file with comments | « Source/devtools/front_end/console/ConsoleView.js ('k') | Source/devtools/front_end/devices/DevicesView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698