Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/ObjectPopoverHelper.js
diff --git a/Source/devtools/front_end/components/ObjectPopoverHelper.js b/Source/devtools/front_end/components/ObjectPopoverHelper.js
index c20454834c592708290e0a5ca59130941fea7034..031dc15e6d4efcfab7fc40dbf834180def35df70 100644
--- a/Source/devtools/front_end/components/ObjectPopoverHelper.js
+++ b/Source/devtools/front_end/components/ObjectPopoverHelper.js
@@ -75,7 +75,7 @@ WebInspector.ObjectPopoverHelper.prototype = {
if (!response)
return;
- var container = document.createElement("div");
+ var container = createElement("div");
container.className = "inline-block";
var title = container.createChild("div", "function-popover-title source-code");
@@ -114,7 +114,7 @@ WebInspector.ObjectPopoverHelper.prototype = {
description = description.trimEnd(WebInspector.ObjectPopoverHelper.MaxPopoverTextLength);
var popoverContentElement = null;
if (result.type !== "object") {
- popoverContentElement = document.createElement("span");
+ popoverContentElement = createElement("span");
popoverContentElement.className = "monospace console-formatted-" + result.type;
popoverContentElement.style.whiteSpace = "pre";
if (result.type === "string")
@@ -131,8 +131,8 @@ WebInspector.ObjectPopoverHelper.prototype = {
result.highlightAsDOMNode();
this._resultHighlightedAsDOM = result;
}
- popoverContentElement = document.createElement("div");
- this._titleElement = document.createElement("div");
+ popoverContentElement = createElement("div");
+ this._titleElement = createElement("div");
this._titleElement.className = "source-frame-popover-title monospace";
this._titleElement.textContent = description;
popoverContentElement.appendChild(this._titleElement);

Powered by Google App Engine
This is Rietveld 408576698