Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3123)

Unified Diff: Source/devtools/front_end/components/HandlerRegistry.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/HandlerRegistry.js
diff --git a/Source/devtools/front_end/components/HandlerRegistry.js b/Source/devtools/front_end/components/HandlerRegistry.js
index 5d9b1f2c0316caaa6d62f7beaf556ce0cae51155..f316b073536a3438c53923cd42b6ee83608ce9ed 100644
--- a/Source/devtools/front_end/components/HandlerRegistry.js
+++ b/Source/devtools/front_end/components/HandlerRegistry.js
@@ -210,7 +210,7 @@ WebInspector.HandlerRegistry.EventTypes = {
WebInspector.HandlerSelector = function(handlerRegistry)
{
this._handlerRegistry = handlerRegistry;
- this.element = document.createElementWithClass("select", "chrome-select");
+ this.element = createElementWithClass("select", "chrome-select");
this.element.addEventListener("change", this._onChange.bind(this), false);
this._update();
this._handlerRegistry.addEventListener(WebInspector.HandlerRegistry.EventTypes.HandlersUpdated, this._update.bind(this));
@@ -225,7 +225,7 @@ WebInspector.HandlerSelector.prototype =
var activeHandler = this._handlerRegistry.activeHandler;
for (var i = 0; i < names.length; ++i) {
- var option = document.createElement("option");
+ var option = createElement("option");
option.textContent = names[i];
option.selected = activeHandler === names[i];
this.element.appendChild(option);
« no previous file with comments | « Source/devtools/front_end/components/FlameChart.js ('k') | Source/devtools/front_end/components/HelpScreen.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698