Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662783002: Cleanup: Only include background_mode_manager.h when ENABLE_BACKGROUND is defined. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Only include background_mode_manager.h when ENABLE_BACKGROUND is defined. Also move some extension headers to ENABLE_EXTENSIONS sections. BUG=424746 Committed: https://crrev.com/e415584fa49388436406239a9c632961fc664a62 Cr-Commit-Position: refs/heads/master@{#300306}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M chrome/browser/browser_process_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 7 chunks +11 lines, -2 lines 2 comments Download
M chrome/browser/prefs/browser_prefs.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 4 chunks +6 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
6 years, 2 months ago (2014-10-17 19:01:55 UTC) #2
Andrew T Wilson (Slow)
LGTM, with one question https://codereview.chromium.org/662783002/diff/1/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): https://codereview.chromium.org/662783002/diff/1/chrome/browser/browser_process_impl.cc#newcode1094 chrome/browser/browser_process_impl.cc:1094: void BrowserProcessImpl::CreateBackgroundModeManager() { Why isn't ...
6 years, 2 months ago (2014-10-20 14:23:02 UTC) #3
Lei Zhang
https://codereview.chromium.org/662783002/diff/1/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): https://codereview.chromium.org/662783002/diff/1/chrome/browser/browser_process_impl.cc#newcode1094 chrome/browser/browser_process_impl.cc:1094: void BrowserProcessImpl::CreateBackgroundModeManager() { On 2014/10/20 14:23:02, Andrew T Wilson ...
6 years, 2 months ago (2014-10-20 18:38:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662783002/1
6 years, 2 months ago (2014-10-20 18:39:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 18:58:14 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 18:59:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e415584fa49388436406239a9c632961fc664a62
Cr-Commit-Position: refs/heads/master@{#300306}

Powered by Google App Engine
This is Rietveld 408576698