chrome/browser/chromeos/login/ui/lock_window_aura.cc - Issue 662763002: Support modal windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/lock_window_aura.cc

Issue 662763002: Support modal windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: fix leaks Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/ui/lock_window_aura.cc

diff --git a/chrome/browser/chromeos/login/ui/lock_window_aura.cc b/chrome/browser/chromeos/login/ui/lock_window_aura.cc

index 464d2ebe3a5eda04a35ed8a27ef036cdbf6e3001..9f0164fd82dee7063cfccef1d88e23ecabcca7ec 100644

--- a/chrome/browser/chromeos/login/ui/lock_window_aura.cc

+++ b/chrome/browser/chromeos/login/ui/lock_window_aura.cc

@@ -70,7 +70,9 @@ void LockWindowAura::Init() {

athena::ScreenManager::ContainerParams container_params(

"LoginScreen", athena::CP_LOGIN_SCREEN);

container_params.can_activate_children = true;

- container_params.grab_inputs = true;

+ container_params.block_events = true;

+ container_params.modal_container_priority =

+ athena::CP_LOGIN_SCREEN_SYSTEM_MODAL;

lock_screen_container_.reset(

athena::ScreenManager::Get()->CreateContainer(container_params));

params.parent = lock_screen_container_.get();