Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: athena/screen/screen_manager_unittest.cc

Issue 662763002: Support modal windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: fix leaks Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « athena/screen/screen_manager_impl.cc ('k') | athena/system/network_selector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/screen/public/screen_manager.h"
6
7 #include <algorithm> 5 #include <algorithm>
8 #include <string> 6 #include <string>
9 7
8 #include "athena/screen/screen_manager_impl.h"
10 #include "athena/test/base/athena_test_base.h" 9 #include "athena/test/base/athena_test_base.h"
10 #include "athena/test/base/test_windows.h"
11 #include "athena/util/container_priorities.h" 11 #include "athena/util/container_priorities.h"
12 #include "ui/aura/test/test_window_delegate.h" 12 #include "ui/aura/test/test_window_delegate.h"
13 #include "ui/aura/window.h" 13 #include "ui/aura/window.h"
14 #include "ui/aura/window_targeter.h"
14 #include "ui/events/test/event_generator.h" 15 #include "ui/events/test/event_generator.h"
15 #include "ui/wm/core/window_util.h" 16 #include "ui/wm/core/window_util.h"
16 17
17 typedef athena::test::AthenaTestBase ScreenManagerTest; 18 typedef athena::test::AthenaTestBase ScreenManagerTest;
18 19
19 namespace athena { 20 namespace athena {
20 namespace { 21 namespace {
21 22
22 const int kTestZOrderPriority = 10; 23 const int kTestZOrderPriority = 10;
23 24
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 ScreenManager::Get()->CreateContainer(activatable); 105 ScreenManager::Get()->CreateContainer(activatable);
105 106
106 scoped_ptr<aura::Window> window( 107 scoped_ptr<aura::Window> window(
107 CreateWindow(no_activatable_container, NULL, gfx::Rect(0, 0, 100, 100))); 108 CreateWindow(no_activatable_container, NULL, gfx::Rect(0, 0, 100, 100)));
108 EXPECT_FALSE(wm::CanActivateWindow(window.get())); 109 EXPECT_FALSE(wm::CanActivateWindow(window.get()));
109 110
110 activatable_container->AddChild(window.get()); 111 activatable_container->AddChild(window.get());
111 EXPECT_TRUE(wm::CanActivateWindow(window.get())); 112 EXPECT_TRUE(wm::CanActivateWindow(window.get()));
112 } 113 }
113 114
114 TEST_F(ScreenManagerTest, GrabInputContainer) { 115 TEST_F(ScreenManagerTest, BlockInputsShouldNotBlockVirtualKeyboard) {
116 ScreenManager::ContainerParams block_params("blocking", kTestZOrderPriority);
117 block_params.can_activate_children = true;
118 block_params.block_events = true;
119 aura::Window* block_container =
120 ScreenManager::Get()->CreateContainer(block_params);
121
122 aura::test::EventCountDelegate block_delegate;
123 scoped_ptr<aura::Window> block_window(CreateWindow(
124 block_container, &block_delegate, gfx::Rect(0, 0, 100, 100)));
125 EXPECT_TRUE(wm::CanActivateWindow(block_window.get()));
126
127 // Create a normal container appearing over the |block_container|. This is
128 // essentially the case of virtual keyboard.
129 ScreenManager::ContainerParams vk_params("virtual keyboard",
130 kTestZOrderPriority + 1);
131 vk_params.can_activate_children = true;
132 aura::Window* vk_container = ScreenManager::Get()->CreateContainer(vk_params);
133
134 aura::test::EventCountDelegate vk_delegate;
135 scoped_ptr<aura::Window> vk_window(
136 CreateWindow(vk_container, &vk_delegate, gfx::Rect(0, 20, 100, 80)));
137 EXPECT_TRUE(wm::CanActivateWindow(vk_window.get()));
138
139 ui::test::EventGenerator event_generator(root_window());
140 event_generator.MoveMouseTo(10, 25);
141 event_generator.ClickLeftButton();
142 EXPECT_EQ("0 0", block_delegate.GetMouseButtonCountsAndReset());
143 EXPECT_EQ("1 1", vk_delegate.GetMouseButtonCountsAndReset());
144 }
145
146 TEST_F(ScreenManagerTest, DefaultContainer) {
147 ScreenManagerImpl* impl =
148 static_cast<ScreenManagerImpl*>(ScreenManager::Get());
149 aura::Window* original_default = impl->FindContainerByPriority(CP_DEFAULT);
150 aura::Window* parent = original_default->parent();
151 // Temporarily remove the original default container from tree.
152 parent->RemoveChild(original_default);
153
154 ScreenManager::ContainerParams params("new_default", CP_END + 1);
155 params.default_parent = true;
156 params.modal_container_priority = CP_END + 2;
157 aura::Window* new_default = ScreenManager::Get()->CreateContainer(params);
158 aura::Window* w = test::CreateNormalWindow(NULL, NULL).release();
159 EXPECT_EQ(new_default, w->parent());
160 delete new_default;
161
162 // Add the original back to shutdown properly.
163 parent->AddChild(original_default);
164 }
165
166 namespace {
167
168 class ScreenManagerTargeterTest
169 : public athena::test::AthenaTestBase,
170 public testing::WithParamInterface<bool> {
171 public:
172 ScreenManagerTargeterTest()
173 : targeter_(GetParam() ? NULL : new aura::WindowTargeter) {}
174 virtual ~ScreenManagerTargeterTest() {}
175
176 protected:
177 scoped_ptr<ui::EventTargeter> targeter_;
178
179 private:
180 DISALLOW_COPY_AND_ASSIGN(ScreenManagerTargeterTest);
181 };
182
183 } // namespace
184
185 TEST_P(ScreenManagerTargeterTest, BlockContainer) {
115 ScreenManager::ContainerParams normal_params( 186 ScreenManager::ContainerParams normal_params(
116 "normal", kTestZOrderPriority); 187 "normal", kTestZOrderPriority);
117 normal_params.can_activate_children = true; 188 normal_params.can_activate_children = true;
118 aura::Window* normal_container = 189 aura::Window* normal_container =
119 ScreenManager::Get()->CreateContainer(normal_params); 190 ScreenManager::Get()->CreateContainer(normal_params);
191 normal_container->SetEventTargeter(targeter_.Pass());
120 192
121 aura::test::EventCountDelegate normal_delegate; 193 aura::test::EventCountDelegate normal_delegate;
122 scoped_ptr<aura::Window> normal_window(CreateWindow( 194 scoped_ptr<aura::Window> normal_window(CreateWindow(
123 normal_container, &normal_delegate, gfx::Rect(0, 0, 100, 100))); 195 normal_container, &normal_delegate, gfx::Rect(0, 0, 100, 100)));
124 196
125 EXPECT_TRUE(wm::CanActivateWindow(normal_window.get())); 197 EXPECT_TRUE(wm::CanActivateWindow(normal_window.get()));
126 wm::ActivateWindow(normal_window.get()); 198 wm::ActivateWindow(normal_window.get());
127 ui::test::EventGenerator event_generator(root_window()); 199 ui::test::EventGenerator event_generator(root_window());
128 event_generator.MoveMouseTo(0, 0); 200 event_generator.MoveMouseTo(0, 0);
129 event_generator.ClickLeftButton(); 201 event_generator.ClickLeftButton();
130 EXPECT_EQ("1 1", normal_delegate.GetMouseButtonCountsAndReset()); 202 EXPECT_EQ("1 1", normal_delegate.GetMouseButtonCountsAndReset());
131 event_generator.PressKey(ui::VKEY_A, ui::EF_NONE); 203 event_generator.PressKey(ui::VKEY_A, ui::EF_NONE);
132 event_generator.ReleaseKey(ui::VKEY_A, ui::EF_NONE); 204 event_generator.ReleaseKey(ui::VKEY_A, ui::EF_NONE);
133 EXPECT_EQ("1 1", normal_delegate.GetKeyCountsAndReset()); 205 EXPECT_EQ("1 1", normal_delegate.GetKeyCountsAndReset());
134 206
135 ScreenManager::ContainerParams grab_params( 207 ScreenManager::ContainerParams block_params("blocking",
136 "grabbing", kTestZOrderPriority + 1); 208 kTestZOrderPriority + 1);
137 grab_params.can_activate_children = true; 209 block_params.can_activate_children = true;
138 grab_params.grab_inputs = true; 210 block_params.block_events = true;
139 aura::Window* grab_container = 211 aura::Window* block_container =
140 ScreenManager::Get()->CreateContainer(grab_params); 212 ScreenManager::Get()->CreateContainer(block_params);
141 213
142 EXPECT_FALSE(wm::CanActivateWindow(normal_window.get())); 214 EXPECT_FALSE(wm::CanActivateWindow(normal_window.get()));
143 215
144 aura::test::EventCountDelegate grab_delegate; 216 aura::test::EventCountDelegate block_delegate;
145 scoped_ptr<aura::Window> grab_window(CreateWindow( 217 scoped_ptr<aura::Window> block_window(CreateWindow(
146 grab_container, &grab_delegate, gfx::Rect(10, 10, 100, 100))); 218 block_container, &block_delegate, gfx::Rect(10, 10, 100, 100)));
147 EXPECT_TRUE(wm::CanActivateWindow(grab_window.get())); 219 EXPECT_TRUE(wm::CanActivateWindow(block_window.get()));
148 220
149 wm::ActivateWindow(grab_window.get()); 221 wm::ActivateWindow(block_window.get());
150 222
151 // (0, 0) is still on normal_window, but the event should not go there 223 // (0, 0) is still on normal_window, but the event should not go there
152 // because grabbing_container prevents it. 224 // because blockbing_container prevents it.
153 event_generator.MoveMouseTo(0, 0); 225 event_generator.MoveMouseTo(0, 0);
154 event_generator.ClickLeftButton(); 226 event_generator.ClickLeftButton();
155 EXPECT_EQ("0 0", normal_delegate.GetMouseButtonCountsAndReset()); 227 EXPECT_EQ("0 0", normal_delegate.GetMouseButtonCountsAndReset());
156 EXPECT_EQ("0 0", grab_delegate.GetMouseButtonCountsAndReset()); 228 EXPECT_EQ("0 0", block_delegate.GetMouseButtonCountsAndReset());
229 event_generator.MoveMouseWheel(0, 10);
230 // EXPECT_EQ(0, normal_event_counter.num_scroll_events());
157 231
158 event_generator.MoveMouseTo(20, 20); 232 event_generator.MoveMouseTo(20, 20);
159 event_generator.ClickLeftButton(); 233 event_generator.ClickLeftButton();
160 EXPECT_EQ("1 1", grab_delegate.GetMouseButtonCountsAndReset()); 234 EXPECT_EQ("1 1", block_delegate.GetMouseButtonCountsAndReset());
161 235
162 event_generator.PressKey(ui::VKEY_A, ui::EF_NONE); 236 event_generator.PressKey(ui::VKEY_A, ui::EF_NONE);
163 event_generator.ReleaseKey(ui::VKEY_A, ui::EF_NONE); 237 event_generator.ReleaseKey(ui::VKEY_A, ui::EF_NONE);
164 EXPECT_EQ("0 0", normal_delegate.GetKeyCountsAndReset()); 238 EXPECT_EQ("0 0", normal_delegate.GetKeyCountsAndReset());
165 EXPECT_EQ("1 1", grab_delegate.GetKeyCountsAndReset()); 239 EXPECT_EQ("1 1", block_delegate.GetKeyCountsAndReset());
166 } 240 }
167 241
168 TEST_F(ScreenManagerTest, GrabShouldNotBlockVirtualKeyboard) { 242 TEST_P(ScreenManagerTargeterTest, BlockAndMouseCapture) {
169 ScreenManager::ContainerParams grab_params("grabbing", kTestZOrderPriority);
170 grab_params.can_activate_children = true;
171 grab_params.grab_inputs = true;
172 aura::Window* grab_container =
173 ScreenManager::Get()->CreateContainer(grab_params);
174
175 aura::test::EventCountDelegate grab_delegate;
176 scoped_ptr<aura::Window> grab_window(
177 CreateWindow(grab_container, &grab_delegate, gfx::Rect(0, 0, 100, 100)));
178 EXPECT_TRUE(wm::CanActivateWindow(grab_window.get()));
179
180 // Create a normal container appearing over the |grab_container|. This is
181 // essentially the case of virtual keyboard.
182 ScreenManager::ContainerParams vk_params(
183 "virtual keyboard", kTestZOrderPriority + 1);
184 vk_params.can_activate_children = true;
185 aura::Window* vk_container = ScreenManager::Get()->CreateContainer(vk_params);
186
187 aura::test::EventCountDelegate vk_delegate;
188 scoped_ptr<aura::Window> vk_window(
189 CreateWindow(vk_container, &vk_delegate, gfx::Rect(0, 20, 100, 80)));
190 EXPECT_TRUE(wm::CanActivateWindow(vk_window.get()));
191
192 ui::test::EventGenerator event_generator(root_window());
193 event_generator.MoveMouseTo(10, 25);
194 event_generator.ClickLeftButton();
195 EXPECT_EQ("0 0", grab_delegate.GetMouseButtonCountsAndReset());
196 EXPECT_EQ("1 1", vk_delegate.GetMouseButtonCountsAndReset());
197 }
198
199 TEST_F(ScreenManagerTest, GrabAndMouseCapture) {
200 ScreenManager::ContainerParams normal_params( 243 ScreenManager::ContainerParams normal_params(
201 "normal", kTestZOrderPriority); 244 "normal", kTestZOrderPriority);
202 normal_params.can_activate_children = true; 245 normal_params.can_activate_children = true;
203 aura::Window* normal_container = 246 aura::Window* normal_container =
204 ScreenManager::Get()->CreateContainer(normal_params); 247 ScreenManager::Get()->CreateContainer(normal_params);
248 normal_container->SetEventTargeter(targeter_.Pass());
205 249
206 aura::test::EventCountDelegate normal_delegate; 250 aura::test::EventCountDelegate normal_delegate;
207 scoped_ptr<aura::Window> normal_window(CreateWindow( 251 scoped_ptr<aura::Window> normal_window(CreateWindow(
208 normal_container, &normal_delegate, gfx::Rect(0, 0, 100, 100))); 252 normal_container, &normal_delegate, gfx::Rect(0, 0, 100, 100)));
209 253
210 ui::test::EventGenerator event_generator(root_window()); 254 ui::test::EventGenerator event_generator(root_window());
211 event_generator.MoveMouseTo(0, 0); 255 event_generator.MoveMouseTo(0, 0);
212 event_generator.PressLeftButton(); 256 event_generator.PressLeftButton();
213 257
214 // Creating grabbing container while mouse pressing. 258 // Creating blocking container while mouse pressing.
215 ScreenManager::ContainerParams grab_params( 259 ScreenManager::ContainerParams block_params("blocking",
216 "grabbing", kTestZOrderPriority + 1); 260 kTestZOrderPriority + 1);
217 grab_params.can_activate_children = true; 261 block_params.can_activate_children = true;
218 grab_params.grab_inputs = true; 262 block_params.block_events = true;
219 aura::Window* grab_container = 263 aura::Window* block_container =
220 ScreenManager::Get()->CreateContainer(grab_params); 264 ScreenManager::Get()->CreateContainer(block_params);
221 265
222 aura::test::EventCountDelegate grab_delegate; 266 aura::test::EventCountDelegate block_delegate;
223 scoped_ptr<aura::Window> grab_window(CreateWindow( 267 scoped_ptr<aura::Window> block_window(CreateWindow(
224 grab_container, &grab_delegate, gfx::Rect(10, 10, 100, 100))); 268 block_container, &block_delegate, gfx::Rect(10, 10, 100, 100)));
225 269
226 // Release event should be sent to |normal_window| because it captures the 270 // Release event should be sent to |normal_window| because it captures the
227 // mouse event. 271 // mouse event.
228 event_generator.ReleaseLeftButton(); 272 event_generator.ReleaseLeftButton();
229 EXPECT_EQ("1 1", normal_delegate.GetMouseButtonCountsAndReset()); 273 EXPECT_EQ("1 1", normal_delegate.GetMouseButtonCountsAndReset());
230 EXPECT_EQ("0 0", grab_delegate.GetMouseButtonCountsAndReset()); 274 EXPECT_EQ("0 0", block_delegate.GetMouseButtonCountsAndReset());
231 275
232 // After release, further mouse events should not be sent to |normal_window| 276 // After release, further mouse events should not be sent to |normal_window|
233 // because grab_container grabs the input. 277 // because block_container blocks the input.
234 event_generator.ClickLeftButton(); 278 event_generator.ClickLeftButton();
235 EXPECT_EQ("0 0", normal_delegate.GetMouseButtonCountsAndReset()); 279 EXPECT_EQ("0 0", normal_delegate.GetMouseButtonCountsAndReset());
236 EXPECT_EQ("0 0", grab_delegate.GetMouseButtonCountsAndReset()); 280 EXPECT_EQ("0 0", block_delegate.GetMouseButtonCountsAndReset());
237 } 281 }
238 282
283 INSTANTIATE_TEST_CASE_P(WithOrWithoutTargeter,
284 ScreenManagerTargeterTest,
285 testing::Values(false, true));
286
239 } // namespace athena 287 } // namespace athena
OLDNEW
« no previous file with comments | « athena/screen/screen_manager_impl.cc ('k') | athena/system/network_selector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698