Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 662733002: Clamp scroll offset to min/max in PopupListBox::updateScrollbars. (Closed)

Created:
6 years, 2 months ago by skobes
Modified:
6 years, 2 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Clamp scroll offset to min/max in PopupListBox::updateScrollbars. This was previously done in ScrollView::setScrollOffsetFromUpdateScrollbars but got lost with http://crrev.com/598093008. BUG=424042 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M Source/web/PopupListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupListBox.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
skobes
(japhet for Source/web OWNERS)
6 years, 2 months ago (2014-10-16 23:05:47 UTC) #2
Mike West
LGTM.
6 years, 2 months ago (2014-10-17 08:14:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662733002/1
6 years, 2 months ago (2014-10-17 09:40:10 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 09:47:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183870

Powered by Google App Engine
This is Rietveld 408576698