Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 66273003: Fix memory leak in sticky keys unit test. (Closed)

Created:
7 years, 1 month ago by Tim Song
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
groby-ooo-7-16, chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Fix memory leak in sticky keys unit test. TEST=tools/valgrind/chrome_tests.sh -t ash_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/wm/sticky_keys_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tim Song
Please take a look. This is currently breaking memory buildbots.
7 years, 1 month ago (2013-11-08 22:54:04 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-08 23:16:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/66273003/1
7 years, 1 month ago (2013-11-08 23:17:58 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 04:33:24 UTC) #4
Message was sent while issue was closed.
Change committed as 234091

Powered by Google App Engine
This is Rietveld 408576698