Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 662723006: Share test framework between js-perf-tests. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Share test framework between js-perf-tests. Also small reformat in Iterators/forof.js R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24682

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -741 lines) Patch
D test/js-perf-test/Collections/base.js View 1 chunk +0 lines, -367 lines 0 comments Download
M test/js-perf-test/Collections/run.js View 1 chunk +1 line, -1 line 0 comments Download
D test/js-perf-test/Iterators/base.js View 1 chunk +0 lines, -367 lines 0 comments Download
M test/js-perf-test/Iterators/forof.js View 1 chunk +12 lines, -6 lines 0 comments Download
M test/js-perf-test/Iterators/run.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/js-perf-test/base.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 2 months ago (2014-10-17 07:09:06 UTC) #1
Michael Achenbach
lgtm - the downside is: when we move the tests to a deeper subdir, all ...
6 years, 2 months ago (2014-10-17 07:35:09 UTC) #2
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-17 09:11:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698