Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 662723002: Support fullscreen api for chrome shell (Closed)

Created:
6 years, 2 months ago by qinmin
Modified:
6 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support fullscreen api for chrome shell This change enabled fullscreen api for chrome shell Committed: https://crrev.com/2d6e305a6dbed90249c9be9225bb1b98a793f25a Cr-Commit-Position: refs/heads/master@{#300031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
6 years, 2 months ago (2014-10-16 22:47:34 UTC) #2
Ted C
lgtm
6 years, 2 months ago (2014-10-16 22:56:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662723002/1
6 years, 2 months ago (2014-10-16 23:04:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 00:49:33 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:50:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d6e305a6dbed90249c9be9225bb1b98a793f25a
Cr-Commit-Position: refs/heads/master@{#300031}

Powered by Google App Engine
This is Rietveld 408576698